[pull] master from grpc:master #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
github-actions
bot
added
lang/core
lang/c++
area/infra
lang/ObjC
lang/php
lang/python
lang/ruby
lang/C#
labels
pull
bot
added
⤵️ pull
and removed
lang/core
lang/c++
area/infra
lang/ObjC
lang/php
lang/python
lang/ruby
lang/C#
labels
github-actions
bot
added
lang/core
lang/c++
area/infra
lang/ObjC
lang/php
lang/python
lang/ruby
lang/C#
labels
) This migrates all of the xDS unit tests except for the fuzzer, which I'll get in a subsequent PR. This also does not include the xDS e2e tests, which I will also do separately. Closes #37896 COPYBARA_INTEGRATE_REVIEW=#37896 from markdroth:xds_tests_use_real_protos2 de568b4 PiperOrigin-RevId: 686197812
Bumps the github-actions group with 2 updates in the / directory: [actions/setup-python](https://github.com/actions/setup-python) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request). Updates `actions/setup-python` from 5.1.0 to 5.2.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p> <blockquote> <h2>v5.2.0</h2> <h2>What's Changed</h2> <h3>Bug fixes:</h3> <ul> <li>Add <code>.zip</code> extension to Windows package downloads for <code>Expand-Archive</code> Compatibility by <a href="https://github.com/priyagupta108"><code>@priyagupta108</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/916">actions/setup-python#916</a> This addresses compatibility issues on Windows self-hosted runners by ensuring that the filenames for Python and PyPy package downloads explicitly include the .zip extension, allowing the Expand-Archive command to function correctly.</li> <li>Add arch to cache key by <a href="https://github.com/Zxilly"><code>@Zxilly</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/896">actions/setup-python#896</a> This addresses issues with caching by adding the architecture (arch) to the cache key, ensuring that cache keys are accurate to prevent conflicts. Note: This change may break previous cache keys as they will no longer be compatible with the new format.</li> </ul> <h3>Documentation changes:</h3> <ul> <li>Fix display of emojis in contributors doc by <a href="https://github.com/sciencewhiz"><code>@sciencewhiz</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/899">actions/setup-python#899</a></li> <li>Documentation update for caching poetry dependencies by <a href="https://github.com/gowridurgad"><code>@gowridurgad</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/908">actions/setup-python#908</a></li> </ul> <h3>Dependency updates:</h3> <ul> <li>Bump <code>@iarna/toml</code> version from 2.2.5 to 3.0.0 by <a href="https://github.com/priya-kinthali"><code>@priya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/912">actions/setup-python#912</a></li> <li>Bump pyinstaller from 3.6 to 5.13.1 by <a href="https://github.com/aparnajyothi-y"><code>@aparnajyothi-y</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/923">actions/setup-python#923</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/sciencewhiz"><code>@sciencewhiz</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/899">actions/setup-python#899</a></li> <li><a href="https://github.com/priyagupta108"><code>@priyagupta108</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/916">actions/setup-python#916</a></li> <li><a href="https://github.com/Zxilly"><code>@Zxilly</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/896">actions/setup-python#896</a></li> <li><a href="https://github.com/aparnajyothi-y"><code>@aparnajyothi-y</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/923">actions/setup-python#923</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5...v5.2.0">https://github.com/actions/setup-python/compare/v5...v5.2.0</a></p> <h2>v5.1.1</h2> <h2>What's Changed</h2> <h3>Bug fixes:</h3> <ul> <li>fix(ci): update all failing workflows by <a href="https://github.com/mayeut"><code>@mayeut</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/863">actions/setup-python#863</a> This update ensures compatibility and optimal performance of workflows on the latest macOS version.</li> </ul> <h3>Documentation changes:</h3> <ul> <li>Documentation update for cache by <a href="https://github.com/gowridurgad"><code>@gowridurgad</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/873">actions/setup-python#873</a></li> </ul> <h3>Dependency updates:</h3> <ul> <li>Bump braces from 3.0.2 to 3.0.3 and undici from 5.28.3 to 5.28.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/893">actions/setup-python#893</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/gowridurgad"><code>@gowridurgad</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/873">actions/setup-python#873</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5...v5.1.1">https://github.com/actions/setup-python/compare/v5...v5.1.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-python/commit/f677139bbe7f9c59b41e40162b753c062f5d49a3"><code>f677139</code></a> Bump pyinstaller from 3.6 to 5.13.1 in /<strong>tests</strong>/data (<a href="https://redirect.github.com/actions/setup-python/issues/923">#923</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/2bd53f9a4d1dd1cd21eaffcc01a7b91a8e73ea4c"><code>2bd53f9</code></a> Documentation update for caching poetry dependencies (<a href="https://redirect.github.com/actions/setup-python/issues/908">#908</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/80b49d3ed89312896dbdcbefc2ddb159c7f8ca43"><code>80b49d3</code></a> fix: add arch to cache key (<a href="https://redirect.github.com/actions/setup-python/issues/896">#896</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/036a5236741fd24c89eea80d1b76179e8e5f9214"><code>036a523</code></a> Fix: Add <code>.zip</code> extension to Windows package downloads for <code>Expand-Archive</code> C...</li> <li><a href="https://github.com/actions/setup-python/commit/04c1311429f7be71707d8ab66c7af8a14e54b938"><code>04c1311</code></a> Fix display of emojis in contributors doc (<a href="https://redirect.github.com/actions/setup-python/issues/899">#899</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/cb6845644151e35f879e10f2f0896c3c8bee372c"><code>cb68456</code></a> Updated <code>@iarna/toml</code> version to 3.0.0 (<a href="https://redirect.github.com/actions/setup-python/issues/912">#912</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/39cd14951b08e74b54015e9e001cdefcf80e669f"><code>39cd149</code></a> Documentation update for cache (<a href="https://redirect.github.com/actions/setup-python/issues/873">#873</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/a0d74c0c423f896bc4e7be91d5cb1e2d54438db3"><code>a0d74c0</code></a> fix(ci): update all failing workflows (<a href="https://redirect.github.com/actions/setup-python/issues/863">#863</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/4eb7dbcb9561cb76a85079ffa9d89b983166e00c"><code>4eb7dbc</code></a> Bump braces from 3.0.2 to 3.0.3 (<a href="https://redirect.github.com/actions/setup-python/issues/893">#893</a>)</li> <li>See full diff in <a href="https://github.com/actions/setup-python/compare/82c7e631bb3cdc910f68e0081d67478d79c6982d...f677139bbe7f9c59b41e40162b753c062f5d49a3">compare view</a></li> </ul> </details> <br /> Updates `peter-evans/create-pull-request` from 6.1.0 to 7.0.5 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p> <blockquote> <h2>Create Pull Request v7.0.5</h2> <p>⚙️ Fixes an issue with commit signing to allow it to support symlinks</p> <h2>What's Changed</h2> <ul> <li>fix: support symlinks when commit signing by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3359">peter-evans/create-pull-request#3359</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.4...v7.0.5">https://github.com/peter-evans/create-pull-request/compare/v7.0.4...v7.0.5</a></p> <h2>Create Pull Request v7.0.4</h2> <p>⚙️ Fixes an issue with commit signing to allow it to support submodules</p> <h2>What's Changed</h2> <ul> <li>docs: correct suggestion for bot setup by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3342">peter-evans/create-pull-request#3342</a></li> <li>build(deps-dev): bump <code>@types/jest</code> from 29.5.12 to 29.5.13 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3343">peter-evans/create-pull-request#3343</a></li> <li>build(deps-dev): bump eslint from 8.57.0 to 8.57.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3344">peter-evans/create-pull-request#3344</a></li> <li>fix: support submodules when commit signing by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3354">peter-evans/create-pull-request#3354</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/henryiii"><code>@henryiii</code></a> made their first contribution in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3342">peter-evans/create-pull-request#3342</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.3...v7.0.4">https://github.com/peter-evans/create-pull-request/compare/v7.0.3...v7.0.4</a></p> <h2>Create Pull Request v7.0.3</h2> <p>⚙️ Fixes an issue with commit signing where commit SHAs have variable lengths when abbreviated.</p> <h2>What's Changed</h2> <ul> <li>fix: disable abbreviated commit shas in diff by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3337">peter-evans/create-pull-request#3337</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.2...v7.0.3">https://github.com/peter-evans/create-pull-request/compare/v7.0.2...v7.0.3</a></p> <h2>Create Pull Request v7.0.2</h2> <p>⚙️ Fixes an issue with commit signing when a change was detected as being a rename or copy.</p> <h2>What's Changed</h2> <ul> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.48 to 18.19.50 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3320">peter-evans/create-pull-request#3320</a></li> <li>build(deps-dev): bump typescript from 5.5.4 to 5.6.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3319">peter-evans/create-pull-request#3319</a></li> <li>fix: disable diff detection for renames and copies by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3330">peter-evans/create-pull-request#3330</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.1...v7.0.2">https://github.com/peter-evans/create-pull-request/compare/v7.0.1...v7.0.2</a></p> <h2>Create Pull Request v7.0.1</h2> <p>⚙️ Fixes <a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3311">an issue</a> affecting one particular use case where the action fails on <code>diff --stat</code> with <code>fatal: ambiguous argument</code>.</p> <h2>What's Changed</h2> <ul> <li>build(deps): bump peter-evans/create-pull-request from 6 to 7 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3283">peter-evans/create-pull-request#3283</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.46 to 18.19.48 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3288">peter-evans/create-pull-request#3288</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 7.17.0 to 7.18.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3289">peter-evans/create-pull-request#3289</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/peter-evans/create-pull-request/commit/5e914681df9dc83aa4e4905692ca88beb2f9e91f"><code>5e91468</code></a> fix: support symlinks when commit signing (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3359">#3359</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/2f38cd26bfebe301a5ee90bdd6550a69dc3ef23f"><code>2f38cd2</code></a> fix: support submodules when commit signing (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3354">#3354</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/7a8aeac749996aed943101d8e7dfb0cecc06197e"><code>7a8aeac</code></a> build(deps-dev): bump eslint from 8.57.0 to 8.57.1 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3344">#3344</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/d39d596a7720fc2c61c9aa5503097fb553431b5e"><code>d39d596</code></a> build(deps-dev): bump <code>@types/jest</code> from 29.5.12 to 29.5.13 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3343">#3343</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/f6f978fd3dc86c443f758f603d22dc554762c832"><code>f6f978f</code></a> docs: correct suggestion for bot setup (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3342">#3342</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/6cd32fd93684475c31847837f87bb135d40a2b79"><code>6cd32fd</code></a> fix: disable abbreviated commit shas in diff (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3337">#3337</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/d121e62763d8cc35b5fb1710e887d6e69a52d3a4"><code>d121e62</code></a> fix: disable diff detection for renames and copies (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3330">#3330</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/f4d66f4d5a5a7e65a185463192800c32d296ac6d"><code>f4d66f4</code></a> build(deps-dev): bump typescript from 5.5.4 to 5.6.2 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3319">#3319</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/488c869d17c8a5cb8a2f0a09471ed82c1d2a084f"><code>488c869</code></a> build(deps-dev): bump <code>@types/node</code> from 18.19.48 to 18.19.50 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3320">#3320</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/5354f85616108575685a73a0ddd2f67c26a441c3"><code>5354f85</code></a> docs: update readme</li> <li>Additional commits viewable in <a href="https://github.com/peter-evans/create-pull-request/compare/c5a7806660adbe173f04e3e038b0ccdcd758773c...5e914681df9dc83aa4e4905692ca88beb2f9e91f">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Corrects bazel run command in README. It does not match the bazel command in the BUILD file. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #37664 COPYBARA_INTEGRATE_REVIEW=#37664 from nolasconapoleao:fix_interceptor_readme 42d828f PiperOrigin-RevId: 686223940
To prepare for the upcoming upgrade to C++17, the following changes were made: Increased minimum supported operating system versions: - iOS: 11 (previously 10) - macOS: 10.14 (previously 10.12) - tvOS: 13.0 (previously 12.0) In addition to this, version requirements across different projects were updated to use these for consistency. Closes #37931 PiperOrigin-RevId: 686519641
…d delete the wrapper in `grpc_take_wrapped_event_engine_endpoint`, which could destroy the wrapper before the refs became zero and lead to use-after-free / illegal instruction / segfault errors if callbacks return after the wrapper is destroyed. Now, we unref the wrapper instead of explicitly deleting it. PiperOrigin-RevId: 705673089
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
Change was created by the release automation script. See go/grpc-release. Closes #38274 PiperOrigin-RevId: 706869858
PiperOrigin-RevId: 706950680
Testing the if combinator 1. Adding one test that asserts the case if the condition promise returns Pending. 2. Asserts which lambda should ( and should not ) be executed for the given conditions. Closes #38294 COPYBARA_INTEGRATE_REVIEW=#38294 from tanvi-jagtap:ph2_combinator_if_tests ee4a074 PiperOrigin-RevId: 707167415
…#38183) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #38183 COPYBARA_INTEGRATE_REVIEW=#38183 from yijiem:httpcli-ee-dns-migration bd09091 PiperOrigin-RevId: 707180165
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #38299 COPYBARA_INTEGRATE_REVIEW=#38299 from ananda1066:remove_pc dbc199a PiperOrigin-RevId: 707207731
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #38310 COPYBARA_INTEGRATE_REVIEW=#38310 from ananda1066:exp 68fb013 PiperOrigin-RevId: 707620925
- Updated opentelemetry-cpp to 1.18.0 (now it's a released one) - Clean up the old `com_github_jupp0r_prometheus_cpp` dep Closes #38317 PiperOrigin-RevId: 707689177
fixes #38298 What happened was that in the rake dock container, Bundler version is 2.6.0; but on the CI host, Bundler version is 2.5.3 When starting the container, Gemfile.lock is mounted to the container as well, which causes in version compatibility issues when it tries to switch back to 2.5.3 in the container. This PR runs bundle update in the container to reconcile the versions of bundler and other germs so the build can succeed. ``` Bundler 2.6.0 is running, but your lockfile was generated with 2.5.3. Installing Bundler 2.5.3 and restarting using that version. Fetching gem metadata from [https://rubygems.org/](https://www.google.com/url?q=https://rubygems.org/&sa=D). Fetching bundler 2.5.3 Installing bundler 2.5.3 ``` Closes #38303 COPYBARA_INTEGRATE_REVIEW=#38303 from alto-ruby:fix-distribution-tests-ruby-linux 1efc15e PiperOrigin-RevId: 707932172
- Updated Bazel 7 to 7.4.1 in RBE/Linux
- Updated Bazel 7 to 7.4.1 in RBE/Windows
…y in EDS (#38312) As per gRFC A76 (grpc/proposal#412). Closes #38312 COPYBARA_INTEGRATE_REVIEW=#38312 from markdroth:ring_hash_changes ae691bb PiperOrigin-RevId: 708054036
PiperOrigin-RevId: 708336431
This is to fix #34297 PR #34103 removed the use of `static threada_local` as class member (not supported on windows) in ExecCtx, now it crashes at a later time in ScopedActivity accessing another static thread_local class memeber. This PR made a similar change by moving it into a function, with this PR, script in the original issue stopped crashing. ``` $ ruby test.rb Never gets here ``` There are still static threada_local class member usages in the following classes: [Context](https://github.com/grpc/grpc/blob/v1.59.0/src/core/lib/promise/context.h#L48) [ScopedSource](https://github.com/grpc/grpc/blob/v1.59.0/src/core/lib/gprpp/time.h#L175) [PerCpuShardingHelper](https://github.com/grpc/grpc/blob/v1.59.0/src/core/lib/gprpp/per_cpu.h#L79) [WorkSerializer::DispatchingWorkSerializer](https://github.com/grpc/grpc/blob/v1.59.0/src/core/lib/gprpp/work_serializer.cc#L387), DEBUG only I'll run more tests to see if they cause crashes as well. -- New crashes with the ExecCtx fix (#34103 ): ``` (gdb) s grpc_core::Activity::ScopedActivity::ScopedActivity (activity=0x1c01d0c7280, this=<synthetic pointer>) at ./src/core/lib/promise/activity.h:241 241 static thread_local Activity* g_current_activity_; (gdb) s 0xffffffff93d10000 in ?? () (gdb) bt #0 0xffffffff93d10000 in ?? () Backtrace stopped: previous frame identical to this frame (corrupt stack?) ``` crash log: ``` -- C level backtrace information ------------------------------------------- C:\Windows\SYSTEM32\ntdll.dll(ZwWaitForSingleObject+0x14) [0x00007ff9dc0a00c4] C:\Windows\System32\KERNELBASE.dll(WaitForSingleObjectEx+0x8e) [0x00007ff9d9a5d77e] C:\Ruby31-x64\bin\x64-ucrt-ruby310.dll(rb_vm_bugreport+0x2b6) [0x00007ff9c184d086] C:\Ruby31-x64\bin\x64-ucrt-ruby310.dll(rb_bug_for_fatal_signal+0x84) [0x00007ff9c163f354] C:\Ruby31-x64\bin\x64-ucrt-ruby310.dll(rb_fiber_scheduler_address_resolve+0x68b) [0x00007ff9c179e7fb] [0x00007ff6d3671e22] C:\Windows\System32\ucrtbase.dll(_C_specific_handler+0xa0) [0x00007ff9d99555f0] C:\Windows\SYSTEM32\ntdll.dll(_chkstk+0x12f) [0x00007ff9dc0a4faf] C:\Windows\SYSTEM32\ntdll.dll(RtlVirtualUnwind2+0x35e) [0x00007ff9dc0318fe] C:\Windows\SYSTEM32\ntdll.dll(KiUserExceptionDispatcher+0x2e) [0x00007ff9dc0a3f9e] [0xffffffff944c0000] C:\Users\hannahshisfb\.local\share\gem\ruby\3.1.0\gems\grpc-1.60.0.dev-x64-mingw-ucrt\grpc_c.64-ucrt.ruby(ZN9grpc_core16BasicMemoryQuota5StartEv+0x6f0) [0x0000000000d280f0] C:\Users\hannahshisfb\.local\share\gem\ruby\3.1.0\gems\grpc-1.60.0.dev-x64-mingw-ucrt\grpc_c.64-ucrt.ruby(ZN9grpc_core13ResourceQuotaC2ENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x1a2) [0 x0000000000d2b612] C:\Users\hannahshisfb\.local\share\gem\ruby\3.1.0\gems\grpc-1.60.0.dev-x64-mingw-ucrt\grpc_c.64-ucrt.ruby(ZN9grpc_core13ResourceQuota7DefaultEv+0x121) [0x0000000000d2b801] C:\Users\hannahshisfb\.local\share\gem\ruby\3.1.0\gems\grpc-1.60.0.dev-x64-mingw-ucrt\grpc_c.64-ucrt.ruby(ZN9grpc_core32EnsureResourceQuotaInChannelArgsERKNS_11ChannelArgsE+0x6a) [0x0000000000d2408a ] C:\Users\hannahshisfb\.local\share\gem\ruby\3.1.0\gems\grpc-1.60.0.dev-x64-mingw-ucrt\grpc_c.64-ucrt.ruby(ZNSt17_Function_handlerIFN9grpc_core11ChannelArgsES1_EPFS1_RKS1_EE9_M_invokeERKSt9_Any_dataO S1_+0x12) [0x0000000001092302] C:\Users\hannahshisfb\.local\share\gem\ruby\3.1.0\gems\grpc-1.60.0.dev-x64-mingw-ucrt\grpc_c.64-ucrt.ruby(ZNK9grpc_core26ChannelArgsPreconditioning23PreconditionChannelArgsEPK17grpc_channel_args+0x4 e) [0x0000000000c9680e] C:\Users\hannahshisfb\.local\share\gem\ruby\3.1.0\gems\grpc-1.60.0.dev-x64-mingw-ucrt\grpc_c.64-ucrt.ruby(grpc_channel_create+0x16f) [0x0000000000bd7d5f] [0x0000000071046591] ``` Closes #34563 COPYBARA_INTEGRATE_REVIEW=#34563 from alto-ruby:no-static-thread-local-member-in-scoped-activity 6fc5419 PiperOrigin-RevId: 708645478
This bumps the minimum version of C++ to 17 from 14 per https://github.com/grpc/proposal/blob/master/L120-requiring-cpp17.md Changes: - Used C++17 instead of C++14 when building gRPC. - Disabled `modernize-unary-static-assert` clang-tidy rule for the smooth transition. This rule will be re-enabled in a future update, along with a fix to address any identified issues. - Added a post-install script for XCode/Cocoapod examples to enforce the use of C++17 across all projects, preventing build errors. (I'd like to have a better solution here but couldn't find it) Closes #37919 PiperOrigin-RevId: 709073401
…endpoint hash key in EDS (#38328) As per gRFC A76 (grpc/proposal#412). This is a second attempt at #38312, which was reverted in #38323. I have temporarily changed back to building ring_hash only in xDS builds to avoid the internal problem that caused the rollback. I still plan to make the change to build ring_hash without xDS, but I will make that change separately once the internal blocker has been resolved. Closes #38328 COPYBARA_INTEGRATE_REVIEW=#38328 from markdroth:ring_hash_changes 2cb77fc PiperOrigin-RevId: 709110527
The gRPC basic turorial says to call the following command to run the server `./route_guide_server --db_path=path/to/route_guide_db.json` But the server and client do not parse command line arguments and they always use default value `route_guide_db.json`. Thus the example only works if we run it from `examples/cpp/route_guide` dir. Otherwise we get the following error: `helper.cc:49] Failed to open route_guide_db.json Aborted (core dumped)` Add `absl::ParseCommandLine(argc, argv);` to both server and client `main` similar to `route_guide_callback_server.cc` Closes #37857 PiperOrigin-RevId: 709154601
Added pawbhard as maintainer <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #38352 COPYBARA_INTEGRATE_REVIEW=#38352 from pawbhard:add_maintainer 2c2c0c2 PiperOrigin-RevId: 710628891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )