feat(service): switch from http to https #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same error handling code is copy-pasted all over the backend. Consolidate this code in 1 common error handler function so it's easier to update next time. Then, fixed the code that's not handling non-cfm-service errors correctly. Also, need to fix potential memory leaks that come from NOT using "defer response.Body.Close()" after a call into cfm-service.
The service provide a self-signed certificate file (.crt) so clients can use secure. Insecure is also available.
…vice-switch-to-https
…nd update (#57) * refactor(cli): command usage and example string generation refactor and update * doc(cli): add docker-specific note about service-related cli options
* feat: set the nodes width based on the device id dimensions * feat: add ipaddress to the existed devices in dashboard * feat: add new button to discover new devices and the related interfaces * fix: fix the bug in addDiscoveredHosts interface * fix: fix bug in addDiscoveredBlades interface * feat: add function addDiscoveredDevices with output popup and waiting popup * style: separate lines for discovered blades and hosts * feat: add waiting progress for device discovery * feat: update the content after adding new discovered devices * feat: distinguish node status by border color * feat: prevent the user from manually adding blades to the CMA_Discovered_Blades appliance * style: remove unnecessary stype setup
…e using privileged mode (#60) * feat: update the docker running command to make D-bus available ay priviledged mode * fix: update the docker running command to make D-bus available using privileged mode
Found a couple bugs in appliance.AddBlade() and manager.AddHost(). (1) corner case where an empty bladeId is being allowed, when it shouldn't (2) Not enough information is being saved to new blade objects during error handling. This was causing a panic during the delete because the backendOps variable was a nil point being used to call a backend function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfm-service needs to change from using http to https.
This PR will switch all 3 cfm components (
service,webui,cli) at the same time, to avoid any confusion\conflicts.At this PR's creation, only
serviceandclihave been switched to using https. Thewebuistill needs to be done. This PR will remain as a "Draft" until that action is complete. Once complete, the PR can go into main and complete the switch to https.