Skip to content

Commit

Permalink
Fix bilibili (langchain-ai#4860)
Browse files Browse the repository at this point in the history
# Fix bilibili api import error

bilibili-api package is depracated and there is no sync module.

<!--
Thank you for contributing to LangChain! Your PR will appear in our next
release under the title you set. Please make sure it highlights your
valuable contribution.

Replace this with a description of the change, the issue it fixes (if
applicable), and relevant context. List any dependencies required for
this change.

After you're done, someone will review your PR. They may suggest
improvements. If no one reviews your PR within a few days, feel free to
@-mention the same people again, as notifications can get lost.
-->

<!-- Remove if not applicable -->

Fixes langchain-ai#2673 langchain-ai#2724 

## Before submitting

<!-- If you're adding a new integration, include an integration test and
an example notebook showing its use! -->

## Who can review?

Community members can review the PR once tests pass. Tag
maintainers/contributors who might be interested:
@vowelparrot  @liaokongVFX 

<!-- For a quicker response, figure out the right person to tag with @

        @hwchase17 - project lead

        Tracing / Callbacks
        - @agola11

        Async
        - @agola11

        DataLoaders
        - @eyurtsev

        Models
        - @hwchase17
        - @agola11

        Agents / Tools / Toolkits
        - @vowelparrot
        
        VectorStores / Retrievers / Memory
        - @dev2049
        
 -->
  • Loading branch information
yuekaizhang authored May 18, 2023
1 parent e462028 commit 1ed4228
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"outputs": [],
"source": [
"#!pip install bilibili-api"
"#!pip install bilibili-api-python"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion langchain/document_loaders/bilibili.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def _get_bilibili_subs_and_info(self, url: str) -> Tuple[str, dict]:
except ImportError:
raise ValueError(
"requests package not found, please install it with "
"`pip install bilibili-api`"
"`pip install bilibili-api-python`"
)

bvid = re.search(r"BV\w+", url)
Expand Down

0 comments on commit 1ed4228

Please sign in to comment.