changed ValueError to ImportError (langchain-ai#5006)

# changed ValueError to ImportError in except Several places with this bug. ValueError does not catch ImportError.
Seldon1224 · May 19, 2023 · 2ab0e1d · 2ab0e1d
1 parent 080eb1b
commit 2ab0e1d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/langchain/docstore/wikipedia.py b/langchain/docstore/wikipedia.py
@@ -15,7 +15,7 @@ def __init__(self) -> None:
         try:
             import wikipedia  # noqa: F401
         except ImportError:
-            raise ValueError(
+            raise ImportError(
                 "Could not import wikipedia python package. "
                 "Please install it with `pip install wikipedia`."
             )

diff --git a/langchain/utilities/arxiv.py b/langchain/utilities/arxiv.py
@@ -58,7 +58,7 @@ def validate_environment(cls, values: Dict) -> Dict:
             )
             values["arxiv_result"] = arxiv.Result
         except ImportError:
-            raise ValueError(
+            raise ImportError(
                 "Could not import arxiv python package. "
                 "Please install it with `pip install arxiv`."
             )

diff --git a/langchain/utilities/wikipedia.py b/langchain/utilities/wikipedia.py
@@ -41,7 +41,7 @@ def validate_environment(cls, values: Dict) -> Dict:
             wikipedia.set_lang(values["lang"])
             values["wiki_client"] = wikipedia
         except ImportError:
-            raise ValueError(
+            raise ImportError(
                 "Could not import wikipedia python package. "
                 "Please install it with `pip install wikipedia`."
             )