Skip to content

Commit

Permalink
Remove duplicate target name for backend/python/targets (pantsbuild…
Browse files Browse the repository at this point in the history 
…#8598)

This has been a TODO since 2016.
  • Loading branch information
@Eric-Arellano
Eric-Arellano authored Nov 8, 2019
1 parent d81ee76 commit 81b9e7c
Show file tree
Hide file tree
Showing 13 changed files with 20 additions and 28 deletions.
2 changes: 1 addition & 1 deletion contrib/python/src/python/pants/contrib/python/checks/tasks/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ python_library(
'3rdparty/python:pex',
':resources',
'src/python/pants/backend/python/subsystems',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/backend/python/tasks',
'src/python/pants/backend/python:interpreter_cache',
'src/python/pants/base:exceptions',
Expand Down
2 changes: 1 addition & 1 deletion pants-plugins/src/python/internal_backend/utilities/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ python_library(
sources=['register.py'],
dependencies=[
'3rdparty/python/twitter/commons:twitter.common.collections',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/backend/python:python_artifact',
'src/python/pants/base:build_environment',
'src/python/pants/base:exceptions',
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/backend/codegen/antlr/python/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

python_library(
dependencies = [
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/jvm/targets:jvm',
'src/python/pants/backend/jvm/tasks:nailgun_task',
'src/python/pants/backend/python/targets',
Expand Down
2 changes: 1 addition & 1 deletion src/python/pants/backend/codegen/thrift/python/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
python_library(
dependencies = [
'src/python/pants/backend/codegen/thrift/lib',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/base:exceptions',
'src/python/pants/engine:fs',
'src/python/pants/goal:task_registrar',
Expand Down
2 changes: 1 addition & 1 deletion src/python/pants/backend/project_info/tasks/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ python_library(
dependencies = [
':idea_resources',
'src/python/pants/backend/jvm/targets:jvm',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/base:build_environment',
'src/python/pants/base:exceptions',
'src/python/pants/base:generator',
Expand Down
4 changes: 2 additions & 2 deletions src/python/pants/backend/python/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ python_library(
':python_requirement',
':python_requirements',
'src/python/pants/backend/python/rules',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/backend/python/tasks',
'src/python/pants/build_graph',
'src/python/pants/goal:task_registrar',
Expand Down Expand Up @@ -55,7 +55,7 @@ python_library(
sources = ['pants_requirement.py'],
dependencies = [
'src/python/pants/backend/python:python_requirement',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/base:build_environment',
'src/python/pants/base:exceptions',
'src/python/pants/build_graph',
Expand Down
7 changes: 0 additions & 7 deletions src/python/pants/backend/python/targets/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,3 @@ python_library(
'src/python/pants/build_graph',
],
)


# TODO: Old name. Remove after all references are fixed to refer directly to the target above.
target(
name = 'python',
dependencies = [':targets'],
)
2 changes: 1 addition & 1 deletion tests/python/pants_test/backend/codegen/grpcio/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

python_tests(
dependencies=[
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/base:build_environment',
'src/python/pants/testutil:task_test_base',
],
Expand Down
2 changes: 1 addition & 1 deletion tests/python/pants_test/backend/codegen/thrift/python/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ python_tests(
'src/python/pants/backend/codegen/thrift/python',
'src/python/pants/backend/python:interpreter_cache',
'src/python/pants/backend/python/subsystems',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/base:build_environment',
'src/python/pants/util:contextutil',
'src/python/pants/testutil/subsystem',
Expand Down
14 changes: 7 additions & 7 deletions tests/python/pants_test/backend/graph_info/tasks/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ python_tests(
dependencies=[
'src/python/pants/backend/graph_info/tasks',
'src/python/pants/backend/jvm/targets:java',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/base:build_environment',
'src/python/pants/testutil:task_test_base',
]
Expand All @@ -34,7 +34,7 @@ python_tests(
'src/python/pants/java/jar',
'src/python/pants/backend/jvm/targets:java',
'src/python/pants/backend/jvm/targets:jvm',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/build_graph',
'src/python/pants/testutil:task_test_base',
]
Expand All @@ -45,7 +45,7 @@ python_tests(
sources = ['test_filemap.py'],
dependencies = [
'src/python/pants/backend/graph_info/tasks',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/build_graph',
'src/python/pants/testutil:task_test_base',
],
Expand All @@ -58,7 +58,7 @@ python_tests(
'src/python/pants/backend/docgen/targets',
'src/python/pants/backend/graph_info/tasks',
'src/python/pants/backend/jvm/targets:java',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/base:exceptions',
'src/python/pants/build_graph',
'src/python/pants/testutil:task_test_base',
Expand All @@ -74,7 +74,7 @@ python_tests(
'src/python/pants/backend/jvm/targets:java',
'src/python/pants/backend/jvm/targets:jvm',
'src/python/pants/build_graph',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/testutil/subsystem',
'src/python/pants/testutil:console_rule_test_base',
],
Expand All @@ -85,7 +85,7 @@ python_tests(
sources = ['test_minimal_cover.py'],
dependencies = [
'src/python/pants/backend/graph_info/tasks',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/build_graph',
'src/python/pants/testutil:task_test_base',
],
Expand Down Expand Up @@ -116,7 +116,7 @@ python_tests(
sources = ['test_sort_targets.py'],
dependencies = [
'src/python/pants/backend/graph_info/tasks',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/build_graph',
'src/python/pants/testutil:task_test_base',
],
Expand Down
2 changes: 1 addition & 1 deletion tests/python/pants_test/backend/project_info/tasks/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ python_tests(
'src/python/pants/backend/jvm/targets:java',
'src/python/pants/backend/jvm/targets:jvm',
'src/python/pants/backend/project_info/tasks:dependencies',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/backend/python:python_requirement',
'src/python/pants/build_graph',
'src/python/pants/testutil:task_test_base',
Expand Down
4 changes: 2 additions & 2 deletions tests/python/pants_test/backend/python/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ python_tests(
dependencies=[
'src/python/pants/backend/python:python_requirement',
'src/python/pants/backend/python:plugin',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/base:build_environment',
'src/python/pants/testutil:test_base',
]
Expand All @@ -17,7 +17,7 @@ python_tests(
name='python_requirement_list',
sources=['test_python_requirement_list.py'],
dependencies=[
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/backend/python:python_requirement',
'src/python/pants/base:exceptions',
'src/python/pants/build_graph',
Expand Down
4 changes: 2 additions & 2 deletions tests/python/pants_test/targets/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ python_tests(
sources = ['test_python_binary.py'],
dependencies = [
':base',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/build_graph',
]
)
Expand All @@ -78,7 +78,7 @@ python_tests(
dependencies = [
'src/python/pants/backend/jvm:artifact',
'src/python/pants/backend/jvm:repository',
'src/python/pants/backend/python/targets:python',
'src/python/pants/backend/python/targets',
'src/python/pants/backend/python:python_artifact',
'src/python/pants/base:exceptions',
'src/python/pants/build_graph',
Expand Down

0 comments on commit 81b9e7c

Please sign in to comment.