Prepare 1.13.0.dev0 release. (pantsbuild#6815)

src/python/pants/VERSION

@@ -1 +1 @@
-1.12.0rc0
+1.13.0.dev0

src/python/pants/notes/master.rst

@@ -4,6 +4,52 @@ Master Pre-Releases
 This document describes ``dev`` releases which occur weekly from master, and which do
 not undergo the vetting associated with ``stable`` releases.
 
+
+1.13.0.dev0 (11/26/2018)
+------------------------
+
+New features
+~~~~~~~~~~~~
+* Header file extensions as options for C/C++ targets (#6802)
+  `PR #6802 <https://github.com/pantsbuild/pants/pull/6802>`_
+
+API Changes
+~~~~~~~~~~~
+* Use both the deprecated and new locations of fatal_warnings args (#6798)
+  `PR #6798 <https://github.com/pantsbuild/pants/pull/6798>`_
+
+Bugfixes
+~~~~~~~~
+* Fix disappearing cursor (#6811)
+  `PR #6811 <https://github.com/pantsbuild/pants/pull/6811>`_
+
+Refactoring, Improvements, and Tooling
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+* Add nailgun-specific main which uses paths in calling process (#6792)
+  `PR #6792 <https://github.com/pantsbuild/pants/pull/6792>`_
+
+* Move file owners computation into the engine and make lighter (#6790)
+  `PR #6790 <https://github.com/pantsbuild/pants/pull/6790>`_
+
+* Bump Conan to 1.9.2 (#6797)
+  `PR #6797 <https://github.com/pantsbuild/pants/pull/6797>`_
+
+* Make bootstrap jar reproducible (#6796)
+  `PR #6796 <https://github.com/pantsbuild/pants/pull/6796>`_
+
+* Remove unused CompilerCacheKey (#6805)
+  `PR #6805 <https://github.com/pantsbuild/pants/pull/6805>`_
+
+* Fix documentation example for using scalac_plugins (#6807)
+  `PR #6807 <https://github.com/pantsbuild/pants/pull/6807>`_
+
+* Remove Params::expect_single compatibility API (#6766)
+  `PR #6766 <https://github.com/pantsbuild/pants/pull/6766>`_
+
+* add integration test for invalidation of ctypes c++ sources (#6801)
+  `PR #6801 <https://github.com/pantsbuild/pants/pull/6801>`_
+
+
 1.12.0rc0 (11/19/2018)
 ----------------------
 

src/python/pants/option/options.py

@@ -8,11 +8,10 @@
 import re
 import sys
 from builtins import object, open, str
-from textwrap import dedent
 
 from twitter.common.collections import OrderedSet
 
-from pants.base.deprecated import get_frame_info, warn_or_error
+from pants.base.deprecated import warn_or_error
 from pants.option.arg_splitter import GLOBAL_SCOPE, ArgSplitter
 from pants.option.global_options import GlobalOptionsRegistrar
 from pants.option.option_util import is_list_option
@@ -341,49 +340,10 @@ def _check_deprecated_scope(self, scope, values):
           deprecated_entity_description='scope {}'.format(deprecated_scope),
           hint='Use scope {} instead (options: {})'.format(scope, ', '.join(explicit_keys)))
 
-  _quiet_flag_regex = make_flag_regex(long_name='quiet', short_name='q')
-
-  # NB: This method can be removed entirely after the deprecation period is complete.
-  def _match_recursive_quiet_flag(self, scope, flags):
-    if scope == GLOBAL_SCOPE:
-      # NB: We do not match a global '-q' or '--quiet' flag -- those are still allowed! Returning
-      # None is explicitly checked for in the _check_deprecations() method.
-      return None
-
-    try:
-      found_flag = next(iter(filter(self._quiet_flag_regex.match, flags)))
-    except StopIteration:
-      # No
-      return None
-
-    if found_flag:
-      return dict(
-        removal_version='1.13.0.dev0',
-        deprecated_entity_description=(
-          "Using the -q or --quiet option recursively "
-          "(i.e. after a goal name on the command line)"),
-        hint=dedent("""
-The -q or --quiet flag should be specified globally by providing it on the
-command line before any other goals (e.g. `./pants -q run
-<binary_target>`). Using -q or --quiet globally will silence all pants logging
-for all tasks and only print output from a console task, which makes binaries
-run from the pants command line usable for consumption by other scripts.
-
-The flag provided was {flag!r}, in scope {scope!r}.
-        """
-        .format(flag=found_flag, scope=scope)),
-        # This shows the call to `self._match_recursive_quiet_flag(...)` in the lambda in
-        # `self.flag_matchers` in the error message so users can know to look at this method for
-        # more context.
-        frame_info=get_frame_info(stacklevel=2),
-        # This warning should always go to stderr, even if a global quiet flag is passed in.
-        ensure_stderr=True)
-
   @memoized_property
   def flag_matchers(self):
     return [
       lambda scope, _, values: self._check_deprecated_scope(scope, values),
-      lambda scope, flags, _: self._match_recursive_quiet_flag(scope, flags),
     ]
 
   def _check_deprecations(self, scope, flags, values):

tests/python/pants_test/bin/BUILD

@@ -2,45 +2,10 @@
 # Licensed under the Apache License, Version 2.0 (see LICENSE).
 
 python_tests(
-  name='loader_integration',
-  sources=['test_loader_integration.py'],
+  sources=rglobs('*.py'),
   dependencies=[
     'src/python/pants/bin',
     'tests/python/pants_test:int-test',
   ],
   tags = {'integration'},
 )
-
-python_tests(
-  name='repro',
-  sources=['test_repro.py'],
-  dependencies=[
-    ':repro_mixin',
-    'src/python/pants/bin',
-    'src/python/pants/fs',
-    'src/python/pants/util:contextutil',
-    'src/python/pants/util:dirutil',
-  ]
-)
-
-python_tests(
-  name='repro_ignore',
-  sources=['test_repro_ignore.py'],
-  dependencies=[
-    ':repro_mixin',
-    'src/python/pants/base:build_root',
-    'src/python/pants/bin',
-    'src/python/pants/fs',
-    'src/python/pants/util:dirutil',
-    'src/python/pants/util:contextutil',
-    'tests/python/pants_test:int-test',
-  ]
-)
-
-python_library(
-  name='repro_mixin',
-  sources=['repro_mixin.py'],
-  dependencies=[
-    'src/python/pants/util:dirutil',
-  ]
-)

tests/python/pants_test/option/test_options_integration.py

@@ -237,12 +237,6 @@ def test_command_line_option_unused_by_goals(self):
     self.assert_success(self.run_pants(['goals', '--bundle-jvm-archive=zip']))
     self.assert_failure(self.run_pants(['goals', '--jvm-invalid=zip']))
 
-  def test_recursive_quiet_deprecated(self):
-    pants_run = self.run_pants(['options', '-q'])
-    self.assert_success(pants_run)
-    self.assertIn("DeprecationWarning: DEPRECATED: Using the -q or --quiet option recursively",
-                  pants_run.stderr_data)
-
   def test_non_recursive_quiet_no_output(self):
     pants_run = self.run_pants(['-q', 'compile'])
     self.assert_success(pants_run)

tests/python/pants_test/releases/test_reversion.py

@@ -39,8 +39,8 @@ def test_run(self):
       output_name = name_template.format(output_version)
       output_whl_file = os.path.join(dest_dir, output_name)
       command = [
+          '--quiet',
           'run',
-          '-q',
           'src/python/pants/releases:reversion',
           '--',
           input_whl_file,