Fix bugs reported by @vladimir-didenko

cocopon#75 (comment)
ShawnAbshire · Dec 27, 2021 · 67c9e80 · 67c9e80
1 parent 2029099
commit 67c9e80
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/colors/iceberg.vim b/colors/iceberg.vim
@@ -5,7 +5,7 @@
 "
 " File:       iceberg.vim
 " Maintainer: cocopon <[email protected]>
-" Modified:   2021-12-27 20:00+0900
+" Modified:   2021-12-27 20:02+0900
 " License:    MIT
 
 
@@ -119,6 +119,10 @@ if &background == 'light'
   hi TSMethod ctermfg=237 guifg=#505695
   hi TSURI cterm=underline ctermfg=31 gui=underline guifg=#3f83a6 term=underline
   hi ZenSpace ctermbg=125 guibg=#cc517a
+  hi LspDiagnosticsUnderlineInformation cterm=underline ctermfg=130 gui=underline guifg=#c57339 term=underline
+  hi LspDiagnosticsUnderlineHint cterm=underline ctermfg=130 gui=underline guifg=#c57339 term=underline
+  hi LspDiagnosticsUnderlineWarning cterm=underline ctermfg=130 gui=underline guifg=#c57339 term=underline
+  hi LspDiagnosticsUnderlineError cterm=underline ctermfg=125 gui=underline guifg=#cc517a term=underline
   hi icebergALAccentRed ctermfg=125 guifg=#cc517a
 
   if has('nvim')
@@ -240,6 +244,10 @@ else
   hi TSMethod ctermfg=252 guifg=#a3adcb
   hi TSURI cterm=underline ctermfg=109 gui=underline guifg=#89b8c2 term=underline
   hi ZenSpace ctermbg=203 guibg=#e27878
+  hi LspDiagnosticsUnderlineInformation cterm=underline ctermfg=216 gui=underline guifg=#e2a478 term=underline
+  hi LspDiagnosticsUnderlineHint cterm=underline ctermfg=216 gui=underline guifg=#e2a478 term=underline
+  hi LspDiagnosticsUnderlineWarning cterm=underline ctermfg=216 gui=underline guifg=#e2a478 term=underline
+  hi LspDiagnosticsUnderlineError cterm=underline ctermfg=203 gui=underline guifg=#e27878 term=underline
   hi icebergALAccentRed ctermfg=203 guifg=#e27878
 
   if has('nvim')
@@ -421,7 +429,7 @@ hi! link typescriptIdentifier Statement
 hi! link typescriptMessage icebergNormalFg
 hi! link typescriptNull Constant
 hi! link typescriptParens icebergNormalFg
-hi! link LspDiagnosticsDefaultError ErrorMsg
+hi! link LspDiagnosticsDefaultError ALEVirtualTextError
 hi! link LspDiagnosticsDefaultWarning ALEVirtualTextWarning
 hi! link LspDiagnosticsDefaultInformation ALEVirtualTextWarning
 hi! link LspDiagnosticsDefaultHint ALEVirtualTextWarning

diff --git a/src/iceberg.vim b/src/iceberg.vim
@@ -594,6 +594,19 @@ function! s:create_colors(palette) abort
         \ }))
   " }}}
 
+  " [Neovim built-in LSP](https://neovim.io/doc/user/lsp.html)
+  for [key, value] in items({'Error': 'red', 'Warning': 'orange', 'Information': 'orange', 'Hint': 'orange'})
+    call extend(rules, pgmnt#hi#group(
+          \ 'LspDiagnosticsUnderline'..key, {
+          \   'cterm': 'underline',
+          \   'gui': 'underline',
+          \   'term': 'underline',
+          \   'ctermfg': eval('c.'..value),
+          \   'guifg': eval('g.'.value),
+          \ }))
+  endfor
+  " }}}
+
   " Palettes for statusline plugins {{{
   call extend(rules, pgmnt#hi#group(
         \ 'icebergALAccentRed', {
@@ -844,7 +857,7 @@ function! s:create_links() abort
   call add(links, pgmnt#hi#link('typescriptParens', 'icebergNormalFg'))
 
   " [Neovim built-in LSP](https://neovim.io/doc/user/lsp.html)
-  call add(links, pgmnt#hi#link('LspDiagnosticsDefaultError','ErrorMsg'))
+  call add(links, pgmnt#hi#link('LspDiagnosticsDefaultError','ALEVirtualTextError'))
   call add(links, pgmnt#hi#link('LspDiagnosticsDefaultWarning','ALEVirtualTextWarning'))
   call add(links, pgmnt#hi#link('LspDiagnosticsDefaultInformation','ALEVirtualTextWarning'))
   call add(links, pgmnt#hi#link('LspDiagnosticsDefaultHint','ALEVirtualTextWarning'))