Skip to content

Commit

Permalink
[CodeStyle] Add CI for self.assertTrue(np.allclose(...)) (PaddlePaddl…
Browse files Browse the repository at this point in the history
…e#45126)

* Add CI for assert-allclose.

* Update CI script.

* Update check_approval.

* Specify the destination path for the git diff.

* Add test samples.

* Add CI for assert-allclose with \n.

* Update test samples.

* Update ALL_ADDED_LINES_IN_TARGET_PATH.

* update GitHub username to userid, test=document_fix

* add rfc as a specification, test=document_fix

* try to integrate single and multiple rows together, test=document_fix

* remove duplicate dirs, test=document_fix

* add anchor `#background`, test=document_fix

* remove original scripts, test=document_fix

* remove test files, test=document_fix

Co-authored-by: SigureMo <[email protected]>
  • Loading branch information
Yulv-git and SigureMo authored Aug 16, 2022
1 parent c17e6af commit 87ff40b
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions tools/check_file_diff_approvals.sh
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,12 @@ if [ "${EMPTY_GRAD_OP_REGISTERED}" != "" ] && [ "${GIT_PT_ID}" != "" ]; then
check_approval 1 43953930 46782768 22165420 22361972
fi

INVALID_UNITTEST_ASSERT_CHECK=`echo "$ALL_ADDED_LINES" | grep -zoE '\+\s+self\.assert(True|Equal)\((\s*\+\s*)?(np|numpy)\.(allclose|array_equal)[^+]*' || true`
if [ "${INVALID_UNITTEST_ASSERT_CHECK}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
echo_line="It is recommended to use 'np.testing.assert_allclose' and 'np.testing.array_equal' instead of 'self.assertTrue(np.allclose(...))' and 'self.assertTrue(np.array_equal(...))'.\nPlease modify the code below. If anything is unclear, please read the specification [ https://github.com/PaddlePaddle/community/blob/master/rfcs/CodeStyle/20220805_code_style_improvement_for_unittest.md#background ]. If it is a mismatch, please request qili93 (Recommend) or luotao1 review and approve.\nThe code that do not meet the specification are as follows:\n${INVALID_UNITTEST_ASSERT_CHECK}\n"
check_approval 1 16605440 6836917
fi

HAS_MODIFIED_PHI_FILES=`git diff --name-only upstream/$BRANCH | grep "paddle/phi/" || true`
PHI_INCLUDE_FLUID_FILES=""
for CHANGE_FILE in ${HAS_MODIFIED_PHI_FILES}; do
Expand Down

0 comments on commit 87ff40b

Please sign in to comment.