Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The input to qr is fixed. #15

Merged
merged 1 commit into from
Jun 16, 2017
Merged

The input to qr is fixed. #15

merged 1 commit into from
Jun 16, 2017

Conversation

smkia
Copy link
Contributor

@smkia smkia commented Jun 14, 2017

Running demOilFgplvm7 demo results in the following error when calling fgplvmCreate.m:

Error using qr
Use qr(A,0) for economy size decomposition or use qr(A,'matrix') for a
permutation matrix and qr(A,'vector') for a permutation vector.

Error in gpUpdateAD (line 56)
      [Q, R] = qr([Ruu; sqrt(model.beta)*model.K_uf'],  '0');

Error in gpUpdateKernels (line 92)
model = gpUpdateAD(model, X);

Error in gpExpandParam (line 72)
  model = gpUpdateKernels(model, model.X, model.X_u);

Error in gpCreate (line 205)
model = gpExpandParam(model, initParams);

Error in fgplvmCreate (line 41)
model = gpCreate(q, d, X, Y, options);

This is because the second input to qr must be a either string with 'matrix' or 'vector' values, or scalar 0. While in the current version the input is string '0' (line 56 in gp/gpUpdateAD.m).
This pull request simply resolves the bug by changing '0' to scalar 0.

@adamian adamian merged commit 4b5914a into SheffieldML:master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants