error in checking to see if error output is a TextIOBase

Also removed a couple unused objects in a test
Shindora · Feb 6, 2020 · 68f8737 · 68f8737
1 parent e307441
commit 68f8737
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/splunklib/modularinput/event_writer.py b/splunklib/modularinput/event_writer.py
@@ -48,7 +48,7 @@ def __init__(self, output = sys.stdout, error = sys.stderr):
         else:
             self._out = TextIOWrapper(output)
 
-        if isinstance(output, TextIOBase):
+        if isinstance(error, TextIOBase):
             self._err = error
         else:
             self._err = TextIOWrapper(error)

diff --git a/tests/modularinput/test_event.py b/tests/modularinput/test_event.py
@@ -144,9 +144,6 @@ def test_write_xml_is_sane(self):
         out = BytesIO()
         err = BytesIO()
 
-        outwrap = TextIOWrapper(out)
-        errwrap = TextIOWrapper(err)
-
         ew = EventWriter(out, err)
 
         expected_xml = ET.parse(data_open("data/event_maximal.xml")).getroot()