Handle boolean parameters in mail related attributes

ShineShe · Dec 15, 2017 · 5debe74 · 5debe74
1 parent 0c8bf88
commit 5debe74
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 6 deletions.
diff --git a/src/org/traccar/notification/NotificationMail.java b/src/org/traccar/notification/NotificationMail.java
@@ -45,18 +45,18 @@ private static Properties getProperties(PropertiesProvider provider) {
             properties.put("mail.smtp.host", host);
             properties.put("mail.smtp.port", String.valueOf(provider.getInteger("mail.smtp.port", 25)));
 
-            String starttlsEnable = provider.getString("mail.smtp.starttls.enable");
+            Boolean starttlsEnable = provider.getBoolean("mail.smtp.starttls.enable");
             if (starttlsEnable != null) {
-                properties.put("mail.smtp.starttls.enable", Boolean.parseBoolean(starttlsEnable));
+                properties.put("mail.smtp.starttls.enable", starttlsEnable);
             }
-            String starttlsRequired = provider.getString("mail.smtp.starttls.required");
+            Boolean starttlsRequired = provider.getBoolean("mail.smtp.starttls.required");
             if (starttlsRequired != null) {
-                properties.put("mail.smtp.starttls.required", Boolean.parseBoolean(starttlsRequired));
+                properties.put("mail.smtp.starttls.required", starttlsRequired);
             }
 
-            String sslEnable = provider.getString("mail.smtp.ssl.enable");
+            Boolean sslEnable = provider.getBoolean("mail.smtp.ssl.enable");
             if (sslEnable != null) {
-                properties.put("mail.smtp.ssl.enable", Boolean.parseBoolean(sslEnable));
+                properties.put("mail.smtp.ssl.enable", sslEnable);
             }
             String sslTrust = provider.getString("mail.smtp.ssl.trust");
             if (sslTrust != null) {

diff --git a/src/org/traccar/notification/PropertiesProvider.java b/src/org/traccar/notification/PropertiesProvider.java
@@ -61,4 +61,21 @@ public int getInteger(String key, int defaultValue) {
         }
     }
 
+    public Boolean getBoolean(String key) {
+        if (config != null) {
+            if (config.hasKey(key)) {
+                return config.getBoolean(key);
+            } else {
+                return null;
+            }
+        } else {
+            Object result = extendedModel.getAttributes().get(key);
+            if (result != null) {
+                return result instanceof String ? Boolean.valueOf((String) result) : (Boolean) result;
+            } else {
+                return null;
+            }
+        }
+    }
+
 }