Skip to content

Commit

Permalink
Add valve opening sound to manual valve (tgstation#84049)
Browse files Browse the repository at this point in the history
## About The Pull Request
Adds a squeaky turning sound and hissing sound to opening valve
## Why It's Good For The Game



https://github.com/tgstation/tgstation/assets/92416224/9213a1bd-9bf9-4e49-97b2-0ceb2830a4ad


## Changelog
:cl:
sound: added squeaky turn and gas hissing sound to gas valve
/:cl:
  • Loading branch information
TheBoondock authored Jun 17, 2024
1 parent 2326767 commit afe6aa0
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions code/game/objects/items/devices/transfer_valve.dm
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@
it explodes properly when it gets a signal (and it does).
*/
/obj/item/transfer_valve/proc/toggle_valve(obj/item/tank/target, change_volume = TRUE)
playsound(src, 'sound/effects/valve_opening.ogg', 50)
if(!valve_open && tank_one && tank_two)
var/turf/bombturf = get_turf(src)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ It's like a regular ol' straight pipe, but you can turn it on and off.
normalize_cardinal_directions()
if(animation)
flick("[valve_type]valve_[on][!on]-[set_overlay_offset(piping_layer)]", src)
playsound(src, 'sound/effects/valve_opening.ogg', 50)
icon_state = "[valve_type]valve_[on ? "on" : "off"]-[set_overlay_offset(piping_layer)]"

/**
Expand All @@ -37,6 +38,7 @@ It's like a regular ol' straight pipe, but you can turn it on and off.
. = on
on = to_open
if(on)
playsound(src, 'sound/effects/gas_hissing.ogg', 50)
update_icon_nopipes()
update_parents()
var/datum/pipeline/parent1 = parents[1]
Expand Down
4 changes: 4 additions & 0 deletions sound/attributions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -188,3 +188,7 @@ https://freesound.org/people/BinaryMonkFlint/sounds/333296/
tank_remove_thunk.ogg was made by mixing two sound tracks from Freesound:
https://freesound.org/people/lowdjinn/sounds/533885/ and;
https://freesound.org/people/BMacZero/sounds/96137/

valve_opening.ogg was made by mixing water flowing samples from:
https://freesound.org/people/scriotxstudios/sounds/349111/?attribution=1 and squeaky scrape sound from:
https://freesound.org/people/Department64/sounds/669028/ which was modified with lower pitch
Binary file added sound/effects/gas_hissing.ogg
Binary file not shown.
Binary file added sound/effects/valve_opening.ogg
Binary file not shown.

0 comments on commit afe6aa0

Please sign in to comment.