Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SG] Create new areas for Wingfoiling and Windfoiling #473

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

ornanatan
Copy link
Contributor

Create a new category for Wingfoils:
Sporting Goods > Outdoor Recreation > Boating & Water Sports > Wingfoils
Sporting Goods > Outdoor Recreation > Boating & Water Sports > Wingfoils > Wings
Sporting Goods > Outdoor Recreation > Boating & Water Sports > Wingfoils > Foils
Sporting Goods > Outdoor Recreation > Boating & Water Sports > Wingfoils > Wingfoil Parts
Sporting Goods > Outdoor Recreation > Boating & Water Sports > Wingfoils > Wingfoil Parts > Wing parts
Sporting Goods > Outdoor Recreation > Boating & Water Sports > Wingfoils > Wingfoil Parts > Foil parts
Sporting Goods > Outdoor Recreation > Boating & Water Sports > Wingfoils > Wingfoil Accessories

@ornanatan ornanatan added taxonomy-tree-requests Suggestion to improve to the taxonomy tree 2025-01 labels Nov 27, 2024
@ornanatan ornanatan self-assigned this Nov 27, 2024
Comment on lines 6941 to 6948
name: Wingfoils
children:
- sg-4-1-10-1
- sg-4-1-10-2
- sg-4-1-10-3
- sg-4-1-10-4
- sg-4-1-10-5
attributes: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we keep consistent naming for the area. This is called "Wingfoils" (in plural) and the next section "Windfoil" (in singular). Should we call them "Wingfoiling" and "Windfoiling" for consistency?

Comment on lines 7000 to 7002
name: Wingfoil Protective Gear
children: []
attributes: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If protective gear isn't substantially different across various water sports, we could create a Water Sport Protective Gear category under Boating and Water Sport Apparel, and move Water Sports Helmets inside it, one level deeper.

image

Comment on lines 7066 to 7072
- id: sg-4-1-11-4-3
name: Foil Wings
children: []
attributes:
- color
- pattern
- material
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, sails, not wings, typically apply to windfoiling, right?

image

Comment on lines +7052 to +7092
- id: sg-4-1-11-4-1
name: Foil Masts
children: []
attributes:
- color
- pattern
- material
- id: sg-4-1-11-4-2
name: Foil Fuselages
children: []
attributes:
- color
- pattern
- material
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these also apply to wingfoiling.

Comment on lines +44285 to +44314
- input:
product_category_id: sg-4-1-10
output:
product_category_id:
- '499811'
- input:
product_category_id: sg-4-1-10-1
output:
product_category_id:
- '499811'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing dist files for mappings.

@ricardotejedorsanz ricardotejedorsanz changed the title [SG] Create a new category for Wingfoils [SG] Create new areas for Wingfoiling and Windfoiling Dec 4, 2024
@ricardotejedorsanz ricardotejedorsanz merged commit a1bc7d7 into main Dec 4, 2024
5 checks passed
@ricardotejedorsanz ricardotejedorsanz deleted the create-new-category-for-Wingfoil branch December 4, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025-01 taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants