Terminate app on iOS simulator before install to address iOS 18 change (

#18)
Shopify · Sep 20, 2024 · b6ef2bf · b6ef2bf
1 parent f40fcff
commit b6ef2bf
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/TophatModules/Sources/AppleDeviceKit/Extensions/ShellCommand+SimCtl.swift b/TophatModules/Sources/AppleDeviceKit/Extensions/ShellCommand+SimCtl.swift
@@ -27,6 +27,7 @@ enum SimCtlCommand {
 	case boot(device: String)
 	case install(device: String, bundleUrl: URL)
 	case launch(device: String, bundleIdentifier: String, arguments: [String])
+	case terminate(device: String, bundleIdentifier: String)
 }
 
 extension SimCtlCommand: ShellCommand {
@@ -47,6 +48,9 @@ extension SimCtlCommand: ShellCommand {
 
 			case .launch(let device, let bundleIdentifier, let arguments):
 				return ["simctl", "launch", device, bundleIdentifier] + arguments
+
+			case .terminate(let device, let bundleIdentifier):
+				return ["simctl", "terminate", device, bundleIdentifier]
 		}
 	}
 }
diff --git a/TophatModules/Sources/AppleDeviceKit/Simulator+Device.swift b/TophatModules/Sources/AppleDeviceKit/Simulator+Device.swift
@@ -56,6 +56,9 @@ extension Simulator: Device {
 
 	func install(application: Application) throws {
 		do {
+			// Failure to terminate is permitted as the application may not be running.
+			try? SimCtl.terminate(udid: id, bundleIdentifier: application.bundleIdentifier)
+
 			try SimCtl.install(udid: id, bundleUrl: application.url)
 		} catch {
 			throw DeviceError.failedToInstallApp(bundleUrl: application.url, deviceType: .virtual)

diff --git a/TophatModules/Sources/AppleDeviceKit/Utilities/SimCtl.swift b/TophatModules/Sources/AppleDeviceKit/Utilities/SimCtl.swift
@@ -37,6 +37,10 @@ final class SimCtl {
 	static func launch(udid: String, bundleIdentifier: String, arguments: [String]) throws {
 		try run(command: .simCtl(.launch(device: udid, bundleIdentifier: bundleIdentifier, arguments: arguments)), log: log)
 	}
+
+	static func terminate(udid: String, bundleIdentifier: String) throws {
+		try run(command: .simCtl(.terminate(device: udid, bundleIdentifier: bundleIdentifier)), log: log)
+	}
 }
 
 private extension Simulator {