Skip to content

Commit

Permalink
CI: remove kubeval
Browse files Browse the repository at this point in the history
* manifests are created with helm going forward
* kubeval validates yaml manifests for K8s
* kubeval does not appear to be helpful
* helm validation will be tackled by CMK-10023

Change-Id: I8ebbde9027aa9044f4caff780983cdbf691dd7f8
  • Loading branch information
lisa-pi committed Mar 10, 2022
1 parent 608cf7a commit a4742e9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
12 changes: 1 addition & 11 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -170,17 +170,7 @@ lint-python/pylint: ## check style with Pylint
pylint --rcfile=.pylintrc src tests

.PHONY: lint-yaml
lint-yaml: lint-yaml/yamllint lint-yaml/kubeval-containerised ## check yaml style

.PHONY: lint-yaml/kubeval
lint-yaml/kubeval: ## check Kubernetes yaml with kubeval
kubeval --additional-schema-locations https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master deploy/kubernetes/*

.PHONY: lint-yaml/kubeval-containerised
lint-yaml/kubeval-containerised: ## check Kubernetes yaml with kubeval
./scripts/run-in-docker.sh \
-i garethr/kubeval:0.15.0 \
-c "kubeval --additional-schema-locations https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master deploy/kubernetes/*"
lint-yaml: lint-yaml/yamllint ## check yaml style

.PHONY: lint-yaml/yamllint
lint-yaml/yamllint: ## check yaml formatting with yamllint
Expand Down
3 changes: 0 additions & 3 deletions ci/jenkins/on-gerrit-commit.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ def do_it() {
stage("lint yaml: yamllint") {
run_target(COLLECTOR_IMAGE, "lint-yaml/yamllint", "--entrypoint=");
}
stage("lint yaml: kubeval") {
run_target(COLLECTOR_IMAGE, "lint-yaml/kubeval", "--entrypoint=");
}
}

def run_target(image, target, docker_args) {
Expand Down

0 comments on commit a4742e9

Please sign in to comment.