Skip to content

Commit

Permalink
Update all issues in source code to point to runtime (dotnet#32349)
Browse files Browse the repository at this point in the history
  • Loading branch information
safern authored Feb 18, 2020
1 parent 3a5d9a4 commit 110282c
Show file tree
Hide file tree
Showing 475 changed files with 1,540 additions and 1,543 deletions.
6 changes: 3 additions & 3 deletions src/libraries/Common/src/System/Net/CookieParser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ private static Func<Cookie, string, bool> InternalSetNameMethod
{
if (s_internalSetNameMethod == null)
{
// TODO https://github.com/dotnet/corefx/issues/13607:
// TODO https://github.com/dotnet/runtime/issues/19348:
// We need to use Cookie.InternalSetName instead of the Cookie.set_Name wrapped in a try catch block, as
// Cookie.set_Name keeps the original name if the string is empty or null.
// Unfortunately this API is internal so we use reflection to access it. The method is cached for performance reasons.
Expand All @@ -552,7 +552,7 @@ private static FieldInfo IsQuotedDomainField
{
if (s_isQuotedDomainField == null)
{
// TODO https://github.com/dotnet/corefx/issues/13607:
// TODO https://github.com/dotnet/runtime/issues/19348:
FieldInfo field = typeof(Cookie).GetField("IsQuotedDomain", BindingFlags.Instance | BindingFlags.NonPublic);
Debug.Assert(field != null, "We need to use an internal field named IsQuotedDomain that is declared on Cookie.");
s_isQuotedDomainField = field;
Expand All @@ -569,7 +569,7 @@ private static FieldInfo IsQuotedVersionField
{
if (s_isQuotedVersionField == null)
{
// TODO https://github.com/dotnet/corefx/issues/13607:
// TODO https://github.com/dotnet/runtime/issues/19348:
FieldInfo field = typeof(Cookie).GetField("IsQuotedVersion", BindingFlags.Instance | BindingFlags.NonPublic);
Debug.Assert(field != null, "We need to use an internal field named IsQuotedVersion that is declared on Cookie.");
s_isQuotedVersionField = field;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#nullable enable

// TODO https://github.com/dotnet/corefx/issues/41201: Design and expose this publicly.
// TODO https://github.com/dotnet/runtime/issues/30902: Design and expose this publicly.

namespace System.Runtime.CompilerServices
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public static bool IsNonZeroLowerBoundArraySupported

// Windows - Schannel supports alpn from win8.1/2012 R2 and higher.
// Linux - OpenSsl supports alpn from openssl 1.0.2 and higher.
// OSX - SecureTransport doesn't expose alpn APIs. TODO https://github.com/dotnet/corefx/issues/33016
// OSX - SecureTransport doesn't expose alpn APIs. TODO https://github.com/dotnet/runtime/issues/27727
public static bool SupportsAlpn => (IsWindows && !IsWindows7) ||
((!IsOSX && !IsWindows) &&
(OpenSslVersion.Major >= 1 && (OpenSslVersion.Minor >= 1 || OpenSslVersion.Build >= 2)));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public async Task Credentials_SetToBadCredential_Unauthorized(string uri, bool u
}

[OuterLoop("Uses external server")]
[ActiveIssue("https://github.com/dotnet/corefx/issues/10041")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/17845")]
[ConditionalTheory(nameof(DomainJoinedTestsEnabled))]
[InlineData(false)]
[InlineData(true)]
Expand All @@ -156,7 +156,7 @@ public async Task Credentials_SetToSpecificCredential_ConnectAsSpecificIdentity(
}

[OuterLoop("Uses external server")]
[ActiveIssue("https://github.com/dotnet/corefx/issues/10041")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/17845")]
[ConditionalFact(nameof(DomainProxyTestsEnabled))]
public async Task Proxy_UseAuthenticatedProxyWithNoCredentials_ProxyAuthenticationRequired()
{
Expand All @@ -171,7 +171,7 @@ public async Task Proxy_UseAuthenticatedProxyWithNoCredentials_ProxyAuthenticati
}

[OuterLoop("Uses external server")]
[ActiveIssue("https://github.com/dotnet/corefx/issues/10041")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/17845")]
[ConditionalFact(nameof(DomainProxyTestsEnabled))]
public async Task Proxy_UseAuthenticatedProxyWithDefaultCredentials_OK()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ public async Task GetAsync_AllowAutoRedirectTrue_RedirectFromHttpsToHttp_StatusC
[Fact]
public async Task GetAsync_AllowAutoRedirectTrue_RedirectWithoutLocation_ReturnsOriginalResponse()
{
if (IsWinHttpHandler) // see https://github.com/dotnet/corefx/issues/24819#issuecomment-338776074 for details
if (IsWinHttpHandler) // see https://github.com/dotnet/runtime/issues/23930#issuecomment-338776074 for details
{
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ await ValidateClientCancellationAsync(async () =>
}

[Theory]
[ActiveIssue("https://github.com/dotnet/corefx/issues/28805")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/25760")]
[MemberData(nameof(TwoBoolsAndCancellationMode))]
public async Task GetAsync_CancelDuringResponseBodyReceived_Buffered_TaskCanceledQuickly(bool chunkedTransfer, bool connectionClose, CancellationMode mode)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ await LoopbackServer.CreateServerAsync(async (server, url) =>
}, options);
}

[ActiveIssue("https://github.com/dotnet/corefx/issues/37336")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/29419")]
[Theory]
[InlineData(ClientCertificateOption.Manual)]
[InlineData(ClientCertificateOption.Automatic)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ public async Task GetAsyncWithBasicAuth_ReceiveSetCookie_CookieSent()
{
if (IsWinHttpHandler)
{
// Issue https://github.com/dotnet/corefx/issues/26986
// Issue https://github.com/dotnet/runtime/issues/24979
// WinHttpHandler does not process the cookie.
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ await server.AcceptConnectionSendResponseAndCloseAsync(
}

#if !WINHTTPHANDLER_TEST
[ActiveIssue("https://github.com/dotnet/corefx/issues/42323")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/31380")]
[OuterLoop("Uses external server")]
[PlatformSpecific(TestPlatforms.AnyUnix)] // The default proxy is resolved via WinINet on Windows.
[Theory]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
Assert.False(proxy.Disposed);
}

[ActiveIssue("https://github.com/dotnet/corefx/issues/32809")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/1507")]
[OuterLoop("Uses external server")]
[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
[InlineData(AuthenticationSchemes.Ntlm, true, false)]
Expand Down Expand Up @@ -129,7 +129,7 @@ public void Proxy_UseEnvironmentVariableToSetSystemProxy_RequestGoesThruProxy()
}, UseVersion.ToString()).Dispose();
}

[ActiveIssue("https://github.com/dotnet/corefx/issues/32809")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/1507")]
[OuterLoop("Uses external server")]
[Theory]
[MemberData(nameof(CredentialsForProxy))]
Expand Down Expand Up @@ -220,7 +220,7 @@ public async Task Proxy_HaveNoCredsAndUseAuthenticatedCustomProxy_ProxyAuthentic
}
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/corefx/issues/11057")]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
public async Task Proxy_SslProxyUnsupported_Throws()
{
using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public async Task UseCallback_HaveCredsAndUseAuthenticatedCustomProxyAndPostToSe
{
if (IsWinHttpHandler && PlatformDetection.IsWindows7)
{
// Issue https://github.com/dotnet/corefx/issues/27612
// Issue https://github.com/dotnet/runtime/issues/25268
return;
}

Expand Down Expand Up @@ -201,7 +201,7 @@ public async Task UseCallback_ValidCertificate_ExpectedValuesDuringCallback(Conf
Assert.NotNull(request);

X509ChainStatusFlags flags = chain.ChainStatus.Aggregate(X509ChainStatusFlags.NoError, (cur, status) => cur | status.Status);
bool ignoreErrors = // https://github.com/dotnet/corefx/issues/21922#issuecomment-315555237
bool ignoreErrors = // https://github.com/dotnet/runtime/issues/22644#issuecomment-315555237
RuntimeInformation.IsOSPlatform(OSPlatform.OSX) &&
checkRevocation &&
errors == SslPolicyErrors.RemoteCertificateChainErrors &&
Expand Down Expand Up @@ -350,7 +350,7 @@ public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, Ss
e.InnerException.HResult == SEC_E_BUFFER_TOO_SMALL &&
!PlatformDetection.IsWindows10Version1607OrGreater)
{
// Testing on old Windows versions can hit https://github.com/dotnet/corefx/issues/7812
// Testing on old Windows versions can hit https://github.com/dotnet/runtime/issues/17005
// Ignore SEC_E_BUFFER_TOO_SMALL error on such cases.
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ public async Task GetAsync_AllowedClientSslVersionDiffersFromServer_ThrowsExcept
// Native WinHTTP sometimes uses multiple TCP connections to try other TLS protocols when
// getting TLS protocol failures as part of its TLS fallback algorithm. The loopback server
// doesn't expect this and stops listening for more connections. This causes unexpected test
// failures. See dotnet/corefx https://github.com/dotnet/corefx/issues/8538.
// failures. See https://github.com/dotnet/runtime/issues/17287.
return;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ public async Task GetAsync_IncompleteData_ThrowsHttpRequestException(bool failDu
{
if (IsWinHttpHandler)
{
return; // see https://github.com/dotnet/corefx/issues/39136#issuecomment-508330958
return; // see https://github.com/dotnet/runtime/issues/30115#issuecomment-508330958
}

await LoopbackServer.CreateClientAndServerAsync(async uri =>
Expand Down Expand Up @@ -2365,7 +2365,7 @@ public async Task SendAsync_SendRequestUsingNoBodyMethodToEchoServerWithContent_
{
// .NET Framework also allows the HttpWebRequest and HttpClient APIs to send a request using 'TRACE'
// verb and a request body. The usual response from a server is "400 Bad Request".
// See here for more info: https://github.com/dotnet/corefx/issues/9023
// See here for more info: https://github.com/dotnet/runtime/issues/17475
Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
}
else
Expand Down Expand Up @@ -2541,7 +2541,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, rootUrl) =>
}
#endregion

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/corefx/issues/11057")]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
public async Task GetAsync_InvalidUrl_ExpectedExceptionThrown()
{
string invalidUri = $"http://{Configuration.Sockets.InvalidHost}";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ await LoopbackServer.CreateServerAsync(async (server, serverUrl) =>
});
}

[ActiveIssue("https://github.com/dotnet/corefx/issues/26355")] // We aren't doing IDNA encoding properly
[ActiveIssue("https://github.com/dotnet/runtime/issues/24679")] // We aren't doing IDNA encoding properly
[Theory]
[MemberData(nameof(InternationalHostNames))]
public async Task InternationalRequestHeaderValues_UsesIdnaEncoding_Success(string hostname)
Expand Down Expand Up @@ -87,7 +87,7 @@ await LoopbackServer.CreateServerAsync(async (server, serverUrl) =>
});
}

[ActiveIssue("https://github.com/dotnet/corefx/issues/26355")] // We aren't doing IDNA decoding properly
[ActiveIssue("https://github.com/dotnet/runtime/issues/24679")] // We aren't doing IDNA decoding properly
[Theory]
[MemberData(nameof(InternationalHostNames))]
public async Task InternationalResponseHeaderValues_UsesIdnaDecoding_Success(string hostname)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ private async Task PostHelper(
{
if (useContentLengthUpload)
{
// Ensure that Content-Length is populated (see https://github.com/dotnet/corefx/issues/27245)
// Ensure that Content-Length is populated (see https://github.com/dotnet/runtime/issues/25086)
requestContent.Headers.ContentLength = requestContent.Headers.ContentLength;
}
else
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace System.Net.Http.Functional.Tests
using HttpClientHandler = System.Net.Http.WinHttpClientHandler;
#endif

[ActiveIssue("https://github.com/dotnet/corefx/issues/26539")] // Flaky test
[ActiveIssue("https://github.com/dotnet/runtime/issues/24776")] // Flaky test
public abstract class SchSendAuxRecordHttpTest : HttpClientHandlerTestBase
{
public SchSendAuxRecordHttpTest(ITestOutputHelper output) : base(output) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public async Task WebSocketProtocol_CreateFromConnectedStream_CanSendReceiveData
{
if (PlatformDetection.IsWindows7)
{
// https://github.com/dotnet/corefx/issues/42339
// https://github.com/dotnet/runtime/issues/31382
return;
}

Expand Down Expand Up @@ -204,7 +204,7 @@ public async Task WebSocketProtocol_CreateFromConnectedStream_CloseAsyncClosesSt
{
if (PlatformDetection.IsWindows7)
{
// https://github.com/dotnet/corefx/issues/42339
// https://github.com/dotnet/runtime/issues/31382
return;
}

Expand Down Expand Up @@ -237,7 +237,7 @@ public async Task WebSocketProtocol_CreateFromConnectedStream_CloseAsyncClosesSt
}
}

[ActiveIssue("https://github.com/dotnet/corefx/issues/36016")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/28957")]
[OuterLoop("Uses external servers")]
[Theory]
[MemberData(nameof(EchoServersAndBoolean))]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public abstract class RealFormatterTestsBase
protected abstract string InvariantToStringSingle(float f, string format);

[Theory]
[InlineData(1.23E+22, "1.23E+22")] // [ActiveIssue("https://github.com/dotnet/corefx/issues/42576")]
[InlineData(1.23E+22, "1.23E+22")] // [ActiveIssue("https://github.com/dotnet/runtime/issues/31483")]
public void TestFormatterDouble_Shortest(double value, string expectedResult) => TestFormatterDouble_Standard(value, "R", expectedResult);

[Theory]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public static void LegalKeySizes()
[InlineData(64, false)] // too small
[InlineData(129, false)] // in valid range but not valid increment
[InlineData(384, false)] // too large
// Skip on .NET Framework because change is not ported https://github.com/dotnet/corefx/issues/18690
// Skip on .NET Framework because change is not ported https://github.com/dotnet/runtime/issues/21236
[InlineData(536870928, true)] // number of bits overflows and wraps around to a valid size
public static void InvalidKeySizes(int invalidKeySize, bool skipOnNetfx)
{
Expand Down Expand Up @@ -97,7 +97,7 @@ public static void InvalidKeySizes(int invalidKeySize, bool skipOnNetfx)
[Theory]
[InlineData(64, false)] // smaller than default BlockSize
[InlineData(129, false)] // larger than default BlockSize
// Skip on .NET Framework because change is not ported https://github.com/dotnet/corefx/issues/18690
// Skip on .NET Framework because change is not ported https://github.com/dotnet/runtime/issues/21236
[InlineData(536870928, true)] // number of bits overflows and wraps around to default BlockSize
public static void InvalidIVSizes(int invalidIvSize, bool skipOnNetfx)
{
Expand Down Expand Up @@ -195,7 +195,7 @@ public static void ValidateEncryptorProperties()
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "In .NET Framework AesCryptoServiceProvider requires a set key and throws otherwise. See https://github.com/dotnet/corefx/issues/19023.")]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "In .NET Framework AesCryptoServiceProvider requires a set key and throws otherwise. See https://github.com/dotnet/runtime/issues/21393.")]
public static void ValidateDecryptorProperties()
{
using (Aes aes = AesFactory.Create())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace System.Security.Cryptography.Encryption.Aes.Tests

public static class DecryptorReusabilty
{
// See https://github.com/dotnet/corefx/issues/18903 for details
// See https://github.com/dotnet/runtime/issues/21354 for details
[ConditionalFact(nameof(ShouldDecryptorBeReusable))]
public static void TestDecryptorReusability()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ public static void ImportNoModulus()

[Fact]
#if TESTING_CNG_IMPLEMENTATION
[ActiveIssue("https://github.com/dotnet/corefx/issues/18882", TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/21341", TargetFrameworkMonikers.NetFramework)]
#endif
public static void ImportNoDP()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1340,7 +1340,7 @@ public static void FromInvalidXml()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/corefx/issues/37595", TestPlatforms.OSX)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/29515", TestPlatforms.OSX)]
public static void FromNonsenseXml()
{
// This is DiminishedDPParameters XML, but with a P that is way too long.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void NormalizeDirectorySeparatorTests(string path, string expected)
public void IsCaseInsensitive_OSX()
{
// There have been reports of casing handling not being appropriate on MacOS
// https://github.com/dotnet/corefx/issues/26797
// https://github.com/dotnet/runtime/issues/24898
Assert.False(PathInternal.IsCaseSensitive);
}
}
Expand Down
Loading

0 comments on commit 110282c

Please sign in to comment.