Rename properties and methods on SearchFilters for simplicity #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bisforboman
force-pushed
the
feature/rename-methods-for-SearchFilters
branch
from
2c798ac to
f35c138
Compare
|
The standard for property names in CSharp is PascalCase. I don't want to change standards. I understand what you are trying to do, but I find it more confusing in the end. Say someone looks at intellisence and sees Type_filters and TypeFilters. It is unclear which one should be chosen. We lose clarity with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual changes are in
src/Sidekick.Apis.Poe/Trade/Requests/Filters/SearchFilters.cs.I figured I saw this in some other project I browsed and thought it might be a nice fit there. I think the expressions looks a lot cleaner atleast?