Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Instagram direct download without using yt-dlp #297

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

rjriajul
Copy link
Collaborator

@rjriajul rjriajul commented Mar 7, 2025

This pull request introduces new functionality for downloading videos from Instagram by adding an Instagram downloader API configuration and implementing the necessary logic to support it. The most important changes include updates to the configuration files and the addition of a new method to handle Instagram links.

Configuration updates:

  • bot/core/config_manager.py: Added INSTADL_API configuration parameter to store the Instagram downloader API URL.
  • config_sample.py: Added a sample INSTADL_API configuration parameter for users to set their Instagram downloader API URL.

Functionality updates:

Summary by Sourcery

New Features:

  • Adds support for downloading videos from Instagram directly using an external API.

Copy link

sourcery-ai bot commented Mar 7, 2025

Reviewer's Guide by Sourcery

This pull request adds the functionality to download videos from Instagram by introducing a new Instagram downloader API configuration and implementing the necessary logic to support it. It includes updates to the configuration files and the addition of a new method to handle Instagram links.

Sequence diagram for Instagram direct link generation

sequenceDiagram
  participant User
  participant direct_link_generator
  participant instagram
  participant Config
  participant Instadownload API

  User->>direct_link_generator: Provides Instagram link
  direct_link_generator->>instagram: Calls instagram(link)
  instagram->>Config: Checks INSTADL_API
  alt INSTADL_API is not configured
    instagram-->>direct_link_generator: Raises DirectDownloadLinkException
  else INSTADL_API is configured
    instagram->>Instadownload API: GET /api/video?postUrl=link
    Instadownload API-->>instagram: Returns JSON response (videoUrl)
    alt status == success and videoUrl in data
      instagram-->>direct_link_generator: Returns videoUrl
    else
      instagram-->>direct_link_generator: Raises DirectDownloadLinkException
    end
  end
  direct_link_generator-->>User: Returns direct video URL
Loading

File-Level Changes

Change Details Files
Introduced a new configuration parameter for the Instagram downloader API.
  • Added INSTADL_API to store the Instagram downloader API URL.
  • Added a sample INSTADL_API configuration parameter.
bot/core/config_manager.py
config_sample.py
Implemented a new method to fetch direct video download URLs from Instagram posts.
  • Added an instagram method to handle Instagram links.
  • Updated the direct_link_generator function to call the new instagram method.
bot/helper/mirror_leech_utils/download_utils/direct_link_generator.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rjriajul - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding input validation for the INSTADL_API configuration parameter to ensure it's a valid URL.
  • It would be helpful to include error handling or logging within the instagram function to diagnose issues with the API calls.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +1926 to +1927
except Exception as e:
raise DirectDownloadLinkException(f"ERROR: {e}")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Preserve original traceback using exception chaining.

Consider using 'raise DirectDownloadLinkException(f"ERROR: {e}") from e' so that the underlying exception’s trace is retained, which can assist in debugging.

@@ -27,6 +27,9 @@
# Hyper Tg Downloader
HELPER_TOKENS = ""

#Ista video downloader api
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (typo): Typo in configuration comment.

It appears 'Ista' might be a typo; consider correcting it to 'Insta' or 'Instagram' for clarity.

Suggested change
#Ista video downloader api
#Insta video downloader API

@rjriajul rjriajul merged commit caf15dc into SilentDemonSD:wzv3 Mar 7, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant