feat: update Instagram function to use default API URL if INSTADL_API is not set #298
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not set This commit updates the instagram function in the direct_link_generator.py file to use a default API URL (https://instagramcdn.vercel.app) if the INSTADL_API configuration variable is not provided or is empty. This ensures that the function can still fetch the direct video download URL from an Instagram post even when the INSTADL_API is not set. Signed-off-by: Riajul <[email protected]>
Reviewer's Guide by SourceryThe pull request updates the Instagram function to use a default API URL if No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @rjriajul - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- The code contains a hardcoded URL
https://instagramcdn.vercel.appwhich could be an API key or secret. (link)
Overall Comments:
- Consider adding a descriptive error message when the API request fails.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ) | ||
| full_url = f"{Config.INSTADL_API}/api/video?postUrl={link}" | ||
|
|
||
| api_url = Config.INSTADL_API or 'https://instagramcdn.vercel.app' |
There was a problem hiding this comment.
🚨 issue (security): The code contains a hardcoded URL https://instagramcdn.vercel.app which could be an API key or secret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
instagramfunction in thebot/helper/mirror_leech_utils/download_utils/direct_link_generator.pyfile. The changes improve the handling of the Instagram downloader API by providing a default API URL and simplifying the code structure.Improvements to API handling and code simplification:
bot/helper/mirror_leech_utils/download_utils/direct_link_generator.py: Updated theinstagramfunction to use a default API URL ifConfig.INSTADL_APIis not set, ensuring the function can still operate without a specific API configuration. Simplified the conditional checks for the response data.Summary by Sourcery
Updates the Instagram function to use a default API URL if INSTADL_API is not set, ensuring the function can still operate without a specific API configuration. Simplifies the conditional checks for the response data.
Enhancements: