Unit test: make the new engine name deterministic based on the existi…

…ng engine longhorn-6682 Signed-off-by: Phan Le <[email protected]>
Silvest89 · Sep 29, 2023 · c79146e · c79146e
1 parent d8cd36b
commit c79146e
Showing 1 changed file with 58 additions and 0 deletions.
diff --git a/types/types_test.go b/types/types_test.go
@@ -175,3 +175,61 @@ func (s *TestSuite) TestIsSelectorsInTags(c *C) {
 		c.Assert(actual, Equals, testCase.expected, Commentf(TestErrResultFmt, testName))
 	}
 }
+
+func (s *TestSuite) TestGenerateEngineNameForVolume(c *C) {
+	type testCase struct {
+		volumeName        string
+		currentEngineName string
+
+		expectedEngineName string
+	}
+	testCases := map[string]testCase{
+		"case 1: testvol, new engine": {
+			volumeName:         "testvol",
+			currentEngineName:  "",
+			expectedEngineName: "testvol-e-0",
+		},
+		"case 2: testvol, new engine from old engine version": {
+			volumeName:         "testvol",
+			currentEngineName:  "testvol-e-abcdefgh",
+			expectedEngineName: "testvol-e-1",
+		},
+		"case 3: testvol, new engine from new engine version": {
+			volumeName:         "testvol",
+			currentEngineName:  "testvol-e-0",
+			expectedEngineName: "testvol-e-1",
+		},
+		"case 4: testvol, newer engine from new engine version": {
+			volumeName:         "testvol",
+			currentEngineName:  "testvol-e-1",
+			expectedEngineName: "testvol-e-2",
+		},
+		"case 5: test-vol, new engine": {
+			volumeName:         "test-vol",
+			currentEngineName:  "",
+			expectedEngineName: "test-vol-e-0",
+		},
+		"case 6: test-vol, new engine from old engine version": {
+			volumeName:         "test-vol",
+			currentEngineName:  "test-vol-e-xxxxxxxx",
+			expectedEngineName: "test-vol-e-1",
+		},
+		"case 7: test-vol, new engine from new engine version": {
+			volumeName:         "test-vol",
+			currentEngineName:  "test-vol-e-0",
+			expectedEngineName: "test-vol-e-1",
+		},
+		"case 8: test-vol, newer engine from new engine version": {
+			volumeName:         "test-vol",
+			currentEngineName:  "test-vol-e-1",
+			expectedEngineName: "test-vol-e-2",
+		},
+	}
+
+	for testName, testCase := range testCases {
+		fmt.Printf("testing %v\n", testName)
+
+		actual := GenerateEngineNameForVolume(testCase.volumeName, testCase.currentEngineName)
+		c.Assert(actual, Equals, testCase.expectedEngineName, Commentf(TestErrResultFmt, testName))
+	}
+}