Timer callbacks need weak references

Sj7800 · Nov 24, 2019 · 2a8d0b5 · 2a8d0b5
1 parent 1134549
commit 2a8d0b5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 17 deletions.
diff --git a/ARKit+CoreLocation/POIViewController.swift b/ARKit+CoreLocation/POIViewController.swift
@@ -70,11 +70,9 @@ class POIViewController: UIViewController {
             self.restartAnimation()
         }
 
-        updateInfoLabelTimer = Timer.scheduledTimer(timeInterval: 0.1,
-                                                    target: self,
-                                                    selector: #selector(POIViewController.updateInfoLabel),
-                                                    userInfo: nil,
-                                                    repeats: true)
+		updateInfoLabelTimer = Timer.scheduledTimer(withTimeInterval: 0.1, repeats: true) { [weak self] _ in
+			self?.updateInfoLabel()
+		}
 
         // Set to true to display an arrow which points north.
         // Checkout the comments in the property description and on the readme on this.
@@ -97,12 +95,9 @@ class POIViewController: UIViewController {
         mapView.isHidden = !showMap
 
         if showMap {
-            updateUserLocationTimer = Timer.scheduledTimer(
-                timeInterval: 0.5,
-                target: self,
-                selector: #selector(POIViewController.updateUserLocation),
-                userInfo: nil,
-                repeats: true)
+			updateUserLocationTimer = Timer.scheduledTimer(withTimeInterval: 0.5, repeats: true) { [weak self] _ in
+				self?.updateUserLocation()
+			}
 
             routes?.forEach { mapView.addOverlay($0.polyline) }
         }

diff --git a/Sources/ARKit-CoreLocation/Location Manager/SceneLocationManager.swift b/Sources/ARKit-CoreLocation/Location Manager/SceneLocationManager.swift
@@ -122,12 +122,13 @@ public final class SceneLocationManager {
 public extension SceneLocationManager {
     func run() {
         pause()
-        updateEstimatesTimer = Timer.scheduledTimer(
-                timeInterval: 0.1,
-                target: self,
-                selector: #selector(SceneLocationManager.updateLocationData),
-                userInfo: nil,
-                repeats: true)
+		if #available(iOS 11.0, *) {
+			updateEstimatesTimer = Timer.scheduledTimer(withTimeInterval: 0.5, repeats: true) { [weak self] _ in
+				self?.updateLocationData()
+			}
+		} else {
+			assertionFailure("Needs iOS 9 and 10 support")
+		}
     }
 
     func pause() {