[ecosystem] Improve email form error handling. (aptos-labs#983)

* Fix margin when fullnode_network_key has errors. * Don't crash if user inputs an invalid email.
SkarioT · May 13, 2022 · 440b17b · 440b17b
1 parent 52b929a
commit 440b17b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/ecosystem/platform/server/app/controllers/onboarding_controller.rb b/ecosystem/platform/server/app/controllers/onboarding_controller.rb
@@ -70,6 +70,9 @@ def email_update
     else
       render :email, status: :unprocessable_entity
     end
+  rescue SendEmailJobError
+    current_user.errors.add :email
+    render :email, status: :unprocessable_entity
   end
 
   private

diff --git a/ecosystem/platform/server/app/jobs/send_email_job.rb b/ecosystem/platform/server/app/jobs/send_email_job.rb
@@ -31,7 +31,7 @@ def send_email
     handle_results(results)
   rescue StandardError => e
     Sentry.capture_exception(e)
-    puts "Error: #{e}"
+    raise SendEmailJobError
   end
 
   def email_body

diff --git a/ecosystem/platform/server/app/views/it1_profiles/_form.html.erb b/ecosystem/platform/server/app/views/it1_profiles/_form.html.erb
@@ -75,10 +75,10 @@
           <%= f.text_field :fullnode_address %>
           </div>
 
-          <p class="mb-4">
+          <div class="mb-4">
           <%= f.label :fullnode_network_key, class: "font-mono uppercase block mb-2 text-lg" %>
           <%= f.text_field :fullnode_network_key, pattern: '0x[a-f0-9]{64}' %>
-          </p>
+          </div>
 
           <div class="flex gap-8 md:gap-16 mb-4 items-end">
             <div class="flex-1">