GUI - remove duplicate fullscreen menu entry on macOS

macOS automagically adds an "Enter Fullscreen" entry to the menu. We already provide one of these for all platforms, so disable the macOS specific one. This requires some ObjectiveC funkiness...

app/gui/qt/CMakeLists.txt

@@ -120,6 +120,9 @@ SET(RESOURCES
 # Enable tracy profiler on debug and rel with debug builds
 if(WIN32)
 SET (SOURCES ${SOURCES} ${APP_ROOT}/external/tracy/TracyClient.cpp)
+elseif(APPLE)
+  SET (SOURCES ${SOURCES} ${APP_ROOT}/platform/macos.mm)
+  SET (SOURCES ${SOURCES} ${APP_ROOT}/platform/macos.h)
 endif()
 
 set(ALL_SOURCES ${OSC_SOURCES} ${QT_SOURCES} ${SOURCES} ${EDITOR_SOURCES})
@@ -145,6 +148,7 @@ if (APPLE)
     MACOSX_BUNDLE_SHORT_VERSION_STRING ${PROJECT_VERSION}
     MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION}
     RESOURCE "images/app.icns"
+    LINK_FLAGS "-framework AppKit"
     OUTPUT_NAME ${MACOS_APP_NAME}
     )
   file(

app/gui/qt/main.cpp

@@ -29,6 +29,10 @@
 #include <QtPlatformHeaders\QWindowsWindowFunctions>
 #endif
 
+#ifdef Q_OS_MAC
+    #include "platform/macos.h"
+#endif
+
 int main(int argc, char *argv[])
 {
 
@@ -116,6 +120,8 @@ int main(int argc, char *argv[])
 #elif __APPLE__
   // macOS code goes here
 
+  SonicPi::removeMacosSpecificMenuItems();
+
   QApplication::setAttribute(Qt::AA_UseHighDpiPixmaps);
 
   QMainWindow* splashWindow = new QMainWindow(0, Qt::FramelessWindowHint);

app/gui/qt/platform/macos.h

@@ -0,0 +1,20 @@
+//--
+// This file is part of Sonic Pi: http://sonic-pi.net
+// Full project source: https://github.com/sonic-pi-net/sonic-pi
+// License: https://github.com/sonic-pi-net/sonic-pi/blob/main/LICENSE.md
+//
+// Copyright 2020 by Sam Aaron (http://sam.aaron.name).
+// All rights reserved.
+//
+// Permission is granted for use, copying, modification, and
+// distribution of modified versions of this work as long as this
+// notice is included.
+//++
+
+#pragma once
+
+namespace SonicPi {
+
+void removeMacosSpecificMenuItems();
+
+}

app/gui/qt/platform/macos.mm

@@ -0,0 +1,36 @@
+//--
+// This file is part of Sonic Pi: http://sonic-pi.net
+// Full project source: https://github.com/sonic-pi-net/sonic-pi
+// License: https://github.com/sonic-pi-net/sonic-pi/blob/main/LICENSE.md
+//
+// Copyright 2020 by Sam Aaron (http://sam.aaron.name).
+// All rights reserved.
+//
+// Permission is granted for use, copying, modification, and
+// distribution of modified versions of this work as long as this
+// notice is included.
+//++
+
+#include "macos.h"
+#import <AppKit/NSWindow.h>
+
+namespace SonicPi {
+
+void removeMacosSpecificMenuItems()
+{
+
+#ifdef AVAILABLE_MAC_OS_X_VERSION_10_12_AND_LATER
+  // Remove (don't allow) the "Show Tab Bar" menu item from the "View" menu,
+  // if supported
+
+  if ([NSWindow respondsToSelector:@selector(allowsAutomaticWindowTabbing)])
+  NSWindow.allowsAutomaticWindowTabbing = NO;
+#endif
+
+  // Remove (don't have) the "Enter Full Screen" menu item from the "View"
+  // menu
+
+  [[NSUserDefaults standardUserDefaults] setBool:NO forKey:@"NSFullScreenMenuItemEverywhere"];
+}
+
+}