Skip to content

Commit

Permalink
framework: Relocate a Constraint TODO (RobotLocomotion#10401)
Browse files Browse the repository at this point in the history
The fix for this should happen in vector_gen -- given the preponderance
of uses of solvers::Constraint and SystemConstraint, we should let those
names win, and just fix vector_gen to use that naming convention.
  • Loading branch information
jwnimmer-tri authored Jan 14, 2019
1 parent 8dd7446 commit d0ea849
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 0 additions & 2 deletions systems/framework/system_constraint.h
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,6 @@ class SystemConstraint {

/// Evaluates the function pointer, and check if all of the outputs
/// are within the desired bounds.
// TODO(russt): Resolve names differences across the codebase. The vector
// gen scripts call this IsValid, but Constraint calls it CheckSatisfied.
boolean<T> CheckSatisfied(const Context<T>& context, double tol) const {
DRAKE_DEMAND(tol >= 0.0);
VectorX<T> value(size());
Expand Down
3 changes: 3 additions & 0 deletions tools/vector_gen/lcm_vector_gen.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,9 @@ def generate_accessors(hh, caller_context, fields):
}
"""

# TODO(russt): Resolve names differences across the codebase. The vector gen
# scripts call this IsValid, but the system and solvers Constraint classes call
# it CheckSatisfied.
IS_VALID_BEGIN = """
/// Returns whether the current values of this vector are well-formed.
drake::boolean<T> IsValid() const {
Expand Down

0 comments on commit d0ea849

Please sign in to comment.