Ensure DataTransformer::testSet samples array is not empty (#204)

Smokietr · Feb 25, 2018 · 9e375ca · 9e375ca
1 parent 4562f1d
commit 9e375ca
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/SupportVectorMachine/DataTransformer.php b/src/SupportVectorMachine/DataTransformer.php
@@ -4,6 +4,8 @@
 
 namespace Phpml\SupportVectorMachine;
 
+use Phpml\Exception\InvalidArgumentException;
+
 class DataTransformer
 {
     public static function trainingSet(array $samples, array $labels, bool $targets = false): string
@@ -24,6 +26,10 @@ public static function trainingSet(array $samples, array $labels, bool $targets
 
     public static function testSet(array $samples): string
     {
+        if (empty($samples)) {
+            throw InvalidArgumentException::arrayCantBeEmpty();
+        }
+
         if (!is_array($samples[0])) {
             $samples = [$samples];
         }

diff --git a/tests/SupportVectorMachine/DataTransformerTest.php b/tests/SupportVectorMachine/DataTransformerTest.php
@@ -4,6 +4,7 @@
 
 namespace Phpml\Tests\SupportVectorMachine;
 
+use Phpml\Exception\InvalidArgumentException;
 use Phpml\SupportVectorMachine\DataTransformer;
 use PHPUnit\Framework\TestCase;
 
@@ -78,4 +79,12 @@ public function testProbabilities(): void
 
         $this->assertEquals($probabilities, DataTransformer::probabilities($rawPredictions, $labels));
     }
+
+    public function testThrowExceptionWhenTestSetIsEmpty(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The array has zero elements');
+
+        DataTransformer::testSet([]);
+    }
 }