Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-19-validate_date_invalid_weekday #20

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

Sonic0
Copy link
Owner

@Sonic0 Sonic0 commented May 24, 2024

This PR fix #19 . @lucianosrp can you review the code and give me feedback?

@Sonic0 Sonic0 force-pushed the Issue-19-fix_invalid_weekdays branch from 0da08a5 to ade3e87 Compare May 24, 2024 20:27
Copy link
Contributor

@lucianosrp lucianosrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Indeed the bug was when converting python's datetime into weekdays.
I like this solution!

@Sonic0 Sonic0 merged commit b0f23de into main May 25, 2024
8 checks passed
@Sonic0 Sonic0 deleted the Issue-19-fix_invalid_weekdays branch May 27, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cron.validate(date) yields invalid result if weekday is specified
2 participants