Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore+fix: BED-5514 - CySQL Performance Work #1180

Merged
merged 1 commit into from
Feb 28, 2025
Merged

chore+fix: BED-5514 - CySQL Performance Work #1180

merged 1 commit into from
Feb 28, 2025

Conversation

zinic
Copy link
Contributor

@zinic zinic commented Feb 27, 2025 •
edited
Loading

Description

The following tickets are addressed as part of this changeset:

  • BED-5512: CySQL - Join on the Correct Node ID in All Shortest Paths Harness
  • BED-5511: CySQL - Honor Recursive Traversal Pattern Direction
  • BED-5509: CySQL - Introduce Heuristic OptimizePatternConstraintBalance
  • BED-5508: CySQL - Avoid Overloading Join Conditions
  • BED-5507: CySQL - Avoid Overeager Inner Joins During Traversal

Motivation and Context

Cypher translation should be performant.

How Has This Been Tested?

Many tweaked and added test cases.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

mistahj67
mistahj67 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@mistahj67 mistahj67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, needs a PFC run, and 1 likely copy pasta typo, otherwise LGTM and didn't want to block.

@zinic zinic force-pushed the cysql branch 2 times, most recently from b05b3bb to 50d10d4 Compare February 27, 2025 22:26
@zinic zinic changed the title chore: CySQL Performance Work chore+fix: BED-5514 - CySQL Performance Work Feb 27, 2025
@zinic zinic merged commit d670670 into main Feb 28, 2025
8 checks passed
@zinic zinic deleted the cysql branch February 28, 2025 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mistahj67 mistahj67 mistahj67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zinic @mistahj67