Skip to content

Commit

Permalink
SAK-40434 Fix off-by-one error in isLarge check (sakaiproject#5869)
Browse files Browse the repository at this point in the history
Gradebook uses two different serialization schemes, depending on the
size of the maximum grade that needs to be represented.  The boundary
between these schemes (16384) wasn't properly handled: it would
attempt to use packed serialization but then throw an error because
the value couldn't be represented.
  • Loading branch information
marktriggs authored and bjones86 committed Aug 14, 2018
1 parent 3642039 commit fd0a36b
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ public boolean isNull() {
}

public boolean isLarge() {
return score != null && Double.valueOf(score) > 16384;
return score != null && Double.valueOf(score) >= 16384;
}

public boolean isExcused() {
Expand Down

0 comments on commit fd0a36b

Please sign in to comment.