SAK-29874 use getBoolean for cleaner code instead of comparing string…

…s to true/false SAK-29874 consistent use of boolean fetching from ServerConfigurationService
Spencerx · Sep 16, 2015 · ff1245f · ff1245f
1 parent 763b14b
commit ff1245f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/signup/tool/src/java/org/sakaiproject/signup/tool/downloadEvents/EventWorksheet.java b/signup/tool/src/java/org/sakaiproject/signup/tool/downloadEvents/EventWorksheet.java
@@ -1281,7 +1281,7 @@ private Workbook createAttendanceDataWorksheet(List<SignupMeetingWrapper> wrappe
 	 */
 	public boolean isAttendanceOn(List<SignupMeetingWrapper> wrappers) {
 
-		if ("true".equalsIgnoreCase(sakaiFacade.getServerConfigurationService().getString("signup.enableAttendance","false"))){
+		if (sakaiFacade.getServerConfigurationService().getBoolean("signup.enableAttendance", false)) {
 			for (SignupMeetingWrapper wrp : wrappers) {
 				if (wrp.getMeeting().isAllowAttendance()){
 					return true;

diff --git a/signup/tool/src/java/org/sakaiproject/signup/tool/jsf/NewSignupMeetingBean.java b/signup/tool/src/java/org/sakaiproject/signup/tool/jsf/NewSignupMeetingBean.java
@@ -301,7 +301,7 @@ public boolean isOtherSitesAvailability() {
 		String toolProperty = sakaiFacade.getToolManager().getCurrentPlacement().getConfig().getProperty("signup.other.sites.availability", "default");
 		if (toolProperty.equals("default")) {
 			//If tool property is not set, then consider sakai property
-			String sakaiProperty= "false".equalsIgnoreCase(sakaiFacade.getServerConfigurationService().getString("signup.otherSitesAvailability", "true"))? "false" : "true" ;
+			String sakaiProperty = Boolean.valueOf(sakaiFacade.getServerConfigurationService().getBoolean("signup.otherSitesAvailability", true)).toString();
 			toolProperty = sakaiProperty;
 		}
 		//tool property would take precedence over sakai property

diff --git a/signup/tool/src/java/org/sakaiproject/signup/tool/jsf/SignupMeetingsBean.java b/signup/tool/src/java/org/sakaiproject/signup/tool/jsf/SignupMeetingsBean.java
@@ -1036,7 +1036,7 @@ public boolean isUserLoggedInStatus(){
 	 */
 	public boolean isAttendanceOn() {
 
-		if ("true".equalsIgnoreCase(getSakaiFacade().getServerConfigurationService().getString("signup.enableAttendance","true"))){
+		if (getSakaiFacade().getServerConfigurationService().getBoolean("signup.enableAttendance", true)) {
 			return true;
 		}
 		else{