Cleanup camera after late PR review (home-assistant#77880)

Cleanup changes to camera from home-assistant#77439
Stonos · Sep 6, 2022 · 34da463 · 34da463
1 parent e5ac50f
commit 34da463
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/homeassistant/components/camera/__init__.py b/homeassistant/components/camera/__init__.py
@@ -893,10 +893,11 @@ async def websocket_update_prefs(
     entity_id = changes.pop("entity_id")
     try:
         entity_prefs = await prefs.async_update(entity_id, **changes)
-        connection.send_result(msg["id"], entity_prefs)
     except HomeAssistantError as ex:
         _LOGGER.error("Error setting camera preferences: %s", ex)
         connection.send_error(msg["id"], "update_failed", str(ex))
+    else:
+        connection.send_result(msg["id"], entity_prefs)
 
 
 async def async_handle_snapshot_service(

diff --git a/homeassistant/components/camera/prefs.py b/homeassistant/components/camera/prefs.py
@@ -68,7 +68,8 @@ async def async_update(
     ) -> dict[str, bool | int]:
         """Update camera preferences.
 
-        Returns a dict with the preferences on success or a string on error.
+        Returns a dict with the preferences on success.
+        Raises HomeAssistantError on failure.
         """
         if preload_stream is not UNDEFINED:
             # Prefs already initialized.