Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci against rails7.1 #48

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

mkmn
Copy link

@mkmn mkmn commented Oct 27, 2023

Why?

Rails7.1 was released on 2023/10/05.
Currently, Scimaenaga can only be used with Rails 7.0 or lower.
This Pull Request is to make Scimaenaga compatible with Rails 7.1.

What?

  • Relax rails dependency version.
  • Use the latest version of rspec-rails.

valerauko
valerauko previously approved these changes Oct 27, 2023
@katsuyasu-murata
Copy link

@mkmn
Thank you for this pull request.
As a result of running CI, Rubocop pointed out below, so could you please fix it?

Specify development dependencies in Gemfile. Raw Output: scimaenaga.gemspec:27:3: C: Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile.

@valerauko valerauko dismissed their stale review October 27, 2023 08:24

CI failure

@mkmn mkmn force-pushed the ci_against_rails7_1 branch from 0d81d63 to 099c65d Compare October 28, 2023 08:06
@mkmn
Copy link
Author

mkmn commented Nov 17, 2023

@katsuyasu-murata
It's late.

I was considering making corrections, but I would like to disable Gemspec/DevelopmentDependencies cop for the following reasons.

  • Having multiple gemfiles increases maintenance costs.
  • add_development_dependency can continue to be used.
  • reviewdog only checks added/modified lines.
    • Fixing it may result in new warnings.
    • I would like to address the warnings collectively in a separate pull request.

@valerauko
Copy link

I'm okay with that 👍

Copy link

@katsuyasu-murata katsuyasu-murata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@katsuyasu-murata katsuyasu-murata merged commit 4291639 into StudistCorporation:master Nov 20, 2023
25 checks passed
@mkmn mkmn deleted the ci_against_rails7_1 branch November 21, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants