Support Ruby 3.3 #50
Merged
Support Ruby 3.3 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. Thanks so much for forking, improving, and maintaining this gem! ❤️ |
javan
commented
Jan 5, 2024
| @@ -1,6 +1,9 @@ | |||
| AllCops: | |||
| NewCops: enable | |||
|
|
|||
| Gemspec/RequiredRubyVersion: | |||
| Enabled: false | |||
There was a problem hiding this comment.
Not sure if this change is technically necessary or if there’s a better “fix”, but it resolved this CI failure on my fork:
Running rubocop with reviewdog 🐶 ...
reviewdog: found at least one result in diff
reviewdog: Reporting results for "rubocop"
Warning: [rubocop] reported by reviewdog 🐶
`required_ruby_version` and `TargetRubyVersion` (3.0, which may be specified in .rubocop.yml) should be equal.
Raw Output:
scimaenaga.gemspec:18:29: W: Gemspec/RequiredRubyVersion: `required_ruby_version` and `TargetRubyVersion` (3.0, which may be specified in .rubocop.yml) should be equal.
Error: Process completed with exit code 1.
There was a problem hiding this comment.
I checked some documents:
https://github.com/rubocop/rubocop/blob/master/config/default.yml#L134C2-L145C49
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Gemspec/RequiredRubyVersion
It seems that TargetRubyVersion in rubocop.yml must be specified as 2.5.9 because 2.5.9 is the lowest required_ruby_version.
However we want rubocop to work with ruby 3.x, so I think disabling Gemspec/RequiredRubyVersion is proper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the upper Ruby version constraint to support Ruby 3.3.