Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 3.3.x (x != 0) #52

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Support 3.3.x (x != 0) #52

merged 3 commits into from
Jun 18, 2024

Conversation

znz
Copy link

@znz znz commented Jun 13, 2024

Why?

<= 3.3 means <= 3.3.0, so this cannot install with 3.3.1 or later.

scimaenaga-1.0.2 requires ruby version >= 2.5.9, <= 3.3, which is incompatible
with the current version, ruby 3.3.3p89

What?

< 3.4 supports 3.3.x (x != 0) too.

Caveats

Nothing affects already supported versions.

Copy link

@valerauko valerauko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

scimaenaga.gemspec Show resolved Hide resolved
@mtakeda15
Copy link

@znz
I want to keep updating test.yml when new ruby version is released, so I prefer <= 3.3.3 to <3.4.

@znz znz requested a review from valerauko June 14, 2024 06:59
@mtakeda15 mtakeda15 self-requested a review June 18, 2024 09:40
Copy link

@mtakeda15 mtakeda15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!!

@mtakeda15 mtakeda15 merged commit fe31692 into StudistCorporation:master Jun 18, 2024
30 checks passed
@znz znz deleted the patch-1 branch June 19, 2024 05:27
@krororo krororo mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants