Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation to Slovenian #168

Closed
wants to merge 1 commit into from
Closed

Added translation to Slovenian #168

wants to merge 1 commit into from

Conversation

pro1mantis
Copy link
Contributor

I followed the instructions and added translation to Slovenian.

@pro1mantis
Copy link
Contributor Author

I added Slovene translation for numbers in dicio-numbers.

@pro1mantis
Copy link
Contributor Author

Translation of strings, I made in weblate.

Copy link
Owner

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you add Slovenian to the README, too?

Beware that in order to translate dicio-numbers you would need to write Java code: copying the Mycroft files is roughly 5% of the effort. But since I have not yet written any good documentation on how to translate dicio-numbers in its entirety, for now let's skip that.

You may want to take a look at the dicio-sentences language documentation before making changes, so that you can understand well what all of the symbols do. If you have any question, feel free to ask!

@@ -0,0 +1,2 @@
open: medium
odpri|zaženi|pokaži|? (aplikacijo? .what.)|(.what. aplikacijo?);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
odpri|zaženi|pokaži|? (aplikacijo? .what.)|(.what. aplikacijo?);
odpri|zaženi|pokaži (aplikacijo? .what.)|(.what. aplikacijo?);

I think this is what you want. |? is a syntax error, but leaving the ? would have meant that any sentence would match, since any word except for the .what. capturing group would be optional. If you meant something else, maybe it would be a good idea to split this into multiple sentences instead.

pokaži|pridobi|naloži|kako se začne|poišči? mi? besedilo (za|od| (pesmi)?)? .song.;
zapoj (pesem)? .song.;
.pesem. besedilo;
zapoj|kako se začne|(kako se začne) (|tista ki se začne|govori o|poje o)|(z besedilom) .song.;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a syntax error (the | after the (). Also, I am not sure what this sentence would mean:

  • the piece zapoj|kako se začne|(kako se začne) would match all of the following pieces of texts: "zapoj se zacne", "kako se zacne", "zapoj se kako se zacne", "kako se kako se zacne"
  • tista ki se začne|govori o|poje o would match: "tista ki se začne o o", "tista ki se začne poje o", "tista ki se govori o o", "tista ki se govori poje o"

@pro1mantis pro1mantis closed this Apr 5, 2023
@pro1mantis
Copy link
Contributor Author

I suddenly made force push and the pull request was closed.

@pro1mantis pro1mantis mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants