Fragmentation #100
Open
Fragmentation #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Attribute used is not sufficient to force the compiler to emit symbol for the d7ap_fs buffers. We need to modify the libraries build ordering
Transport layer needs to be informed that the transaction is terminated.
FS initialisation can be done by the alp_layer_init function. But this obliges to start with ALP initilisation prior to the initilisation of the stack D7A. However, D7A stack relies on the D7A FS, and not necessarily on ALP. Thus, it is more safe to invoke explicitely the FS initialisation in the bootstrap prior to the D7A init.
current_tl_received is renitialised when dialog is terminated. If not reinitialised, the automation scan can't be restarted after a master session is terminated.
This feature is only applicable when sending a long request or when receiving an unsollicited request (not for response). One request is handled per fragmentation session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an implementation proposal regarding the new fragmentation feature explained in the PAG mailing list.
As a preliminary, this PR comes with a series of different fixes.
Some of them are coming from our porting of the D7A stack to RIOT.
Thus, the patch fb4ea08 "d7a: registration is only possible when the stack is completely initialized" turned out to be necessary when we operate in a multi-thread RTOS (eg RIOT) where the D7A stack is initialized independently to the client application.
One fix deserves a special attention since it may be CORTUS specific:
68f2e45 fix Cortus build due to missing symbol regarding the d7ap_fs buffers
At least with the CORTUS toolchain, we have to reorder the libraries during the link. To be checked with the other platforms.
Feel free to review them and to cherry-pick them to master independently to the fragmentation feature.
This PR introduces also some missing aspects of the D7A spec, like the retry counter per request, the Execution Delay Timeout (Te)...
This PR has been tested in the case where all fragments are successfully received. The retry mechanism based on the ACK bitmap still requires to be tested.
Meanwhile, I propose this PR for review.
Thanks!