Node Configuration Module for Flexible Client Configuration #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SouzaWander
changed the title
DavideSilva
requested changes
Oct 4, 2023
There was a problem hiding this comment.
You should probably rebase this branch with the branch from PR #5, or with main if you merge it first, so that we only get here the changes that are relevant to this PR
Let me know if you need help doing this, I can give you some pointers on how to do it
|
Thank you for the suggestion! I've actually never done a rebase before, so I would really appreciate some help and pointers on how to do it.😅 |
This commit introduces new client modules that enable users to easily configure their clients with different settings. It also enhances the behavior of client methods by incorporating callback support, allowing for greater flexibility and customization in how clients interact with the system.
SouzaWander
force-pushed
the
ws-node-configurations
branch
from
66546be to
5963714
Compare
DavideSilva
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses Issue #2 by introducing a new module that fetches node configurations from either the application's configuration or the module options. This module enhances the flexibility and configurability of our client, making it easier to use and adapt to different node configurations.
Related Issues:
Closes #2