Skip to content

Commit

Permalink
Remove legacy semantic-highlighting client code. (clangd#273)
Browse files Browse the repository at this point in the history
* Remove legacy semantic-highlighting client code.

The legacy semantic-highlighting support has been dropped since
clangd13.

* Also drop obsolete dependencies

Co-authored-by: Sam McCall <[email protected]>
hokein and sam-mccall authored Jan 25, 2022
1 parent 0636e48 commit f2519af
Showing 5 changed files with 22 additions and 626 deletions.
24 changes: 1 addition & 23 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 21 additions & 22 deletions package.json
Original file line number Diff line number Diff line change
@@ -46,9 +46,7 @@
"dependencies": {
"@clangd/install": "0.1.4",
"abort-controller": "^3.0.0",
"jsonc-parser": "^2.1.0",
"vscode-languageclient": "7.1.0-next.1",
"vscode-languageserver-types": "3.16.0"
"vscode-languageclient": "7.1.0-next.1"
},
"devDependencies": {
"@types/glob": "^7.1.1",
@@ -58,9 +56,9 @@
"clang-format": "1.4.0",
"glob": "^7.1.4",
"mocha": "^9.1.3",
"ovsx": "^0.2.1",
"typescript": "^3.8.3",
"vsce": "^1.93.0",
"ovsx": "^0.2.1",
"vscode-test": "^1.3.0"
},
"repository": {
@@ -104,7 +102,8 @@
"clangd.semanticHighlighting": {
"type": "boolean",
"default": true,
"description": "Enable semantic highlighting in clangd."
"description": "Enable semantic highlighting in clangd.",
"deprecationMessage": "Legacy semanticHighlights is no longer supported. Please use `editor.semanticHighlighting.enabled` instead."
},
"clangd.fallbackFlags": {
"type": "array",
@@ -342,24 +341,24 @@
]
},
"colors": [
{
"id": "clangd.inlayHints.foreground",
"description": "Foreground color of inlay hints",
"defaults": {
"dark": "#A0A0A0F0",
"light": "#747474",
"highContrast": "#BEBEBE"
}
},
{
"id": "clangd.inlayHints.background",
"description": "Background color of inlay hints",
"defaults": {
"dark": "#11223300",
"light": "#11223300",
"highContrast": "#11223300"
{
"id": "clangd.inlayHints.foreground",
"description": "Foreground color of inlay hints",
"defaults": {
"dark": "#A0A0A0F0",
"light": "#747474",
"highContrast": "#BEBEBE"
}
},
{
"id": "clangd.inlayHints.background",
"description": "Background color of inlay hints",
"defaults": {
"dark": "#11223300",
"light": "#11223300",
"highContrast": "#11223300"
}
}
}
]
}
}
3 changes: 0 additions & 3 deletions src/clangd-context.ts
Original file line number Diff line number Diff line change
@@ -9,7 +9,6 @@ import * as inlayHints from './inlay-hints';
import * as install from './install';
import * as memoryUsage from './memory-usage';
import * as openConfig from './open-config';
import * as semanticHighlighting from './semantic-highlighting';
import * as switchSourceHeader from './switch-source-header';
import * as typeHierarchy from './type-hierarchy';

@@ -151,8 +150,6 @@ export class ClangdContext implements vscode.Disposable {
this.client.createDefaultErrorHandler(
// max restart count
config.get<boolean>('restartAfterCrash') ? /*default*/ 4 : 0);
if (config.get<boolean>('semanticHighlighting'))
semanticHighlighting.activate(this);
this.client.registerFeature(new EnableEditsNearCursorFeature);
typeHierarchy.activate(this);
inlayHints.activate(this);
405 changes: 0 additions & 405 deletions src/semantic-highlighting.ts

This file was deleted.

173 changes: 0 additions & 173 deletions test/semantic-highlighting.test.ts

This file was deleted.

0 comments on commit f2519af

Please sign in to comment.