forked from microsoft/vcpkg
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[libvpx,lmdb,aubio,freetype-gl,intelrdfpmathlib,libbson,libtcod,metis…
…,pqp,smpeg2] Build fixes 2022-04-28 (microsoft#24470) * [libvpx,lmdb,aubio,freetype-gl,intelrdfpmathlib,libbson,libtcod,metis,pqp,smpeg2] Build fixes 2022-04-28 These results are from the most recent CI run: https://dev.azure.com/vcpkg/public/_build/results?buildId=71465 PASSING, REMOVE FROM FAIL LIST: aubio:x64-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). I also did some investigation as to why aubio:arm-uwp didn't pass. Turns out, it's because aubio depends on ffmpeg, which failed to build because it depends on libvpx, which we never fixed for UWP following the VS2022 update. See also https://developercommunity.visualstudio.com/t/MicrosoftVisualStudioComponentVCTool/10002207?space=62&scope=follow&sort=newest PASSING, REMOVE FROM FAIL LIST: freetype-gl:x64-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). I also checked freetype-gl:arm-uwp, but it's blocked by glew which is blocked by opengl which appears to not be a thing on arm. PASSING, REMOVE FROM FAIL LIST: intelrdfpmathlib:x64-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). The arm-uwp version of this emits errors that look like source issues; I blocked arm&windows with a supports expression: D:\buildtrees\intelrdfpmathlib\src\athLib20U2-d2a8954428.clean\LIBRARY\src\bid_functions.h(3113): error C2719: 'x': formal parameter with requested alignment of 16 won't be aligned PASSING, REMOVE FROM FAIL LIST: libbson:arm-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). PASSING, REMOVE FROM FAIL LIST: libbson:x64-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). PASSING, REMOVE FROM FAIL LIST: libtcod:arm-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). PASSING, REMOVE FROM FAIL LIST: libtcod:x64-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). PASSING, REMOVE FROM FAIL LIST: lmdb:x64-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). arm-uwp failed with again what looks like a source issue: mdb.c.obj : error LNK2001: unresolved external symbol __tls_used mdb.c.obj : error LNK2001: unresolved external symbol _mdb_tls_cbp PASSING, REMOVE FROM FAIL LIST: metis:arm-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). PASSING, REMOVE FROM FAIL LIST: metis:x64-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). PASSING, REMOVE FROM FAIL LIST: pqp:arm-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). PASSING, REMOVE FROM FAIL LIST: pqp:x64-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). PASSING, REMOVE FROM FAIL LIST: smpeg2:arm-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). PASSING, REMOVE FROM FAIL LIST: smpeg2:x64-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt). I also checked Linux and it says Could NOT find ibverbs (missing: IBVERBS_INCLUDE_DIRS IBVERBS_LIBRARIES) which may be vcpkg's fault so I left that ci.baseline.txt skip alone. REGRESSION: jansson:arm-uwp failed with POST_BUILD_CHECKS_FAILED. If expected, add jansson:arm-uwp=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: jansson:x64-uwp failed with POST_BUILD_CHECKS_FAILED. If expected, add jansson:x64-uwp=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt. Already fixed by microsoft#24466 * dos2unix the patch * :dos2unix the other patches too
- Loading branch information
1 parent
2ece8fe
commit c8a56fd
Showing
12 changed files
with
125 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,21 @@ | ||
diff --git a/build/make/configure.sh b/build/make/configure.sh | ||
index 81d30a16c..d4f19cd97 100644 | ||
--- a/build/make/configure.sh | ||
+++ b/build/make/configure.sh | ||
@@ -1370,12 +1370,14 @@ EOF | ||
case ${tgt_os} in | ||
win32) | ||
add_asflags -f win32 | ||
- enabled debug && add_asflags -g cv8 | ||
+ enabled debug && [ "${AS}" = yasm ] && add_asflags -g cv8 | ||
+ enabled debug && [ "${AS}" = nasm ] && add_asflags -gcv8 | ||
EXE_SFX=.exe | ||
;; | ||
win64) | ||
add_asflags -f win64 | ||
- enabled debug && add_asflags -g cv8 | ||
+ enabled debug && [ "${AS}" = yasm ] && add_asflags -g cv8 | ||
+ enabled debug && [ "${AS}" = nasm ] && add_asflags -gcv8 | ||
EXE_SFX=.exe | ||
;; | ||
linux*|solaris*|android*) | ||
diff --git a/build/make/configure.sh b/build/make/configure.sh | ||
index 81d30a1..325017e 100644 | ||
--- a/build/make/configure.sh | ||
+++ b/build/make/configure.sh | ||
@@ -1370,12 +1370,14 @@ EOF | ||
case ${tgt_os} in | ||
win32) | ||
add_asflags -f win32 | ||
- enabled debug && add_asflags -g cv8 | ||
+ enabled debug && [ "${AS}" = yasm ] && add_asflags -g cv8 | ||
+ enabled debug && [ "${AS}" = nasm ] && add_asflags -gcv8 | ||
EXE_SFX=.exe | ||
;; | ||
win64) | ||
add_asflags -f win64 | ||
- enabled debug && add_asflags -g cv8 | ||
+ enabled debug && [ "${AS}" = yasm ] && add_asflags -g cv8 | ||
+ enabled debug && [ "${AS}" = nasm ] && add_asflags -gcv8 | ||
EXE_SFX=.exe | ||
;; | ||
linux*|solaris*|android*) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
diff --git a/build/make/gen_msvs_vcxproj.sh b/build/make/gen_msvs_vcxproj.sh | ||
index 916851662..e60405bc9 100755 | ||
--- a/build/make/gen_msvs_vcxproj.sh | ||
+++ b/build/make/gen_msvs_vcxproj.sh | ||
@@ -394,7 +394,7 @@ generate_vcxproj() { | ||
else | ||
config_suffix="" | ||
fi | ||
- tag_content TargetName "${name}${lib_sfx}${config_suffix}" | ||
+ tag_content TargetName "${name}" | ||
fi | ||
close_tag PropertyGroup | ||
done | ||
diff --git a/build/make/gen_msvs_vcxproj.sh b/build/make/gen_msvs_vcxproj.sh | ||
index 916851662..e60405bc9 100755 | ||
--- a/build/make/gen_msvs_vcxproj.sh | ||
+++ b/build/make/gen_msvs_vcxproj.sh | ||
@@ -394,7 +394,7 @@ generate_vcxproj() { | ||
else | ||
config_suffix="" | ||
fi | ||
- tag_content TargetName "${name}${lib_sfx}${config_suffix}" | ||
+ tag_content TargetName "${name}" | ||
fi | ||
close_tag PropertyGroup | ||
done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.