fixed non-finite bugs (google#1133)

Suriya1419 · Apr 9, 2020 · ff255de · ff255de
1 parent bae62df
commit ff255de
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/model-viewer/src/three-components/SmoothControls.ts b/packages/model-viewer/src/three-components/SmoothControls.ts
@@ -416,8 +416,11 @@ export class SmoothControls extends EventDispatcher {
                         (radius - minimumRadius!) /
                 (this[$goalLogFov] - Math.log(minimumFieldOfView!));
 
-    const goalRadius =
-        radius + (isFinite(deltaRatio) ? deltaZoom * deltaRatio : 0);
+    const goalRadius = radius +
+        deltaZoom *
+            Math.min(
+                isFinite(deltaRatio) ? deltaRatio : Infinity,
+                maximumRadius! - minimumRadius!);
     let handled = this.setOrbit(goalTheta, goalPhi, goalRadius);
 
     if (deltaZoom !== 0) {