forked from pantsbuild/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add additional directories with register.py to pants bin deps (pantsb…
…uild#19848) I compared the output of `find . -name register.py` and the dependencies of the `src/python/pants/bin:plugins` target: this identified several backends that seemingly weren't being packaged into the Pants binary, and thus not available for users, similar to pantsbuild#19836. - `pants.backend.experimental.helm.check.kubeconform` - `pants.backend.experimental.python.framework.django` - `pants.backend.experimental.python.typecheck.pytype` - `pants.backend.experimental.rust` - `pants.backend.experimental.swift` - `pants.backend.experimental.terraform.lint.tfsec` - `pants.backend.python.providers.experimental.pyenv.custom_install` Two of these (Django and Rust) also had minor issues the caused errors when being loaded, which this PR resolves. There were also two that have been upgraded from experimental to stable, that were depended upon via the old/deprecated experimental name, but not the stable name: - `pants.backend.python.lint.autoflake` - `pants.backend.python.lint.pyupgrade` This doesn't try to solve the problem of keeping this up to date. I can think of two approaches (definitely for a separate PR): - pantsbuild#17301, with a test that reads the `BUILD` file and compares the dependencies to a `find` for `register.py` files - a target that exposes the output of `pants peek ::` as a file, with a test that reads that file and does the appropriate validation
- Loading branch information
Showing
3 changed files
with
23 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters