Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sub directories are not zipped correctly #17

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

XavierBerger
Copy link
Contributor

Context

Unzip Libreoffice odt file works fine.
Zipping again the directory to recreate the file result a corrupted file.

Source of bug

File zipped are not the same as in original unzipped file. The directories are empty and, for some directory some files have been created with the same name

Bug Fix

When recursing over directories, do not perform action on directory and only add files within directories

Validation

I'm using this fix to handle odt files and it works properly. Note: No automated tests are proposed in the MR...

@Sygmei
Copy link
Owner

Sygmei commented Feb 27, 2023

Thanks for your contribution :)

@Sygmei Sygmei merged commit c6887de into Sygmei:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants