Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows runner build issue #8

Merged
merged 1 commit into from
Nov 26, 2021
Merged

fix windows runner build issue #8

merged 1 commit into from
Nov 26, 2021

Conversation

Assertores
Copy link
Contributor

No description provided.

@Assertores Assertores changed the title fix windows runner build issue WIP:fix windows runner build issue Nov 26, 2021
trying hardcore methode

investigate LZMA

workaround: incorrect GitHub CI instalation
@Assertores Assertores changed the title WIP:fix windows runner build issue fix windows runner build issue Nov 26, 2021
@Assertores
Copy link
Contributor Author

we have to fetch 3rd party libraries due to a wrongly configured CI runner. the same is done by the minizip guys as well:
https://github.com/zlib-ng/minizip-ng/blob/99d39015e29703af2612277180ea586805f655ea/.github/workflows/main.yml#L157

@Sygmei
Copy link
Owner

Sygmei commented Nov 26, 2021

Ah great, I was wondering why the Windows CI failed when it worked locally
Thanks a lot for your contribution !

@Sygmei Sygmei merged commit da31106 into Sygmei:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants