Fix: Check comment blocks leading /* on separate line

betty-style.pl

@@ -2952,6 +2952,15 @@ sub process {
 			     "networking block comments don't use an empty /* line, use /* Comment...\n" . $hereprev);
 		}
 
+# Block comments use /* on leading line
+		if ($rawline !~ m@^.\s*/\*\s*$@ &&		#leading /*
+		    $rawline !~ m@^.*/\*.*\*/\s*$@ &&		#inline /*...*/
+		    $rawline !~ m@^.*/\*{2,}\s*$@ &&		#leading /**
+		    $rawline =~ m@^.\s*/\*+.+\s*$@) {		#/* non blank
+			WARN("BLOCK_COMMENT_STYLE",
+			    "Block comments use a leading /* on a separate line\n" . $herecurr);
+		}
+
 # Block comments use * on subsequent lines
 		if ($prevline =~ /$;[ \t]*$/ &&			#ends in comment
 		    $prevrawline =~ /^\+.*?\/\*/ &&		#starting /*

test

@@ -59,7 +59,7 @@ do
 		if [ "$output" != "$exp" ]
 		then
 			echo -e "\t${RED}Error. The output is not the one expected:${NC}"
-			echo $output
+			echo "$output"
 			let errors++
 		else
 			echo -e "\t${GREEN}Test passed successfully!${NC}"
@@ -122,15 +122,15 @@ do
 	if [ "$output" != "$exp_stdout" ]
 	then
 		echo -e "\t${RED}Error. The output (stdout) is not the one expected:${NC}"
-		echo $output
+		echo "$output"
 		let errors++
 	else
 		echo -e "\t${GREEN}Test passed successfully!${NC}"
 	fi
 	if [ "$err" != "$exp_stderr" ]
 	then
 		echo -e "\t${RED}Error. The error output (stderr) is not the one expected:${NC}"
-		echo $err
+		echo "$err"
 		let errors++
 	else
 		echo -e "\t${GREEN}Test passed successfully!${NC}"

tests/style/comments/comments0.c

@@ -14,3 +14,7 @@
 /* Bad
  * multi-line
  * comment */
+
+/** Also
+very bad
+comment*/

tests/style/comments/comments0.expected

@@ -1,3 +1,7 @@
 tests/style/comments/comments0.c:3: ERROR: do not use C99 // comments
+tests/style/comments/comments0.c:14: WARNING: Block comments use a leading /* on a separate line
 tests/style/comments/comments0.c:16: WARNING: Block comments use a trailing */ on a separate line
-total: 1 errors, 1 warnings, 16 lines checked
+tests/style/comments/comments0.c:18: WARNING: Block comments use a leading /* on a separate line
+tests/style/comments/comments0.c:19: WARNING: Block comments use * on subsequent lines
+tests/style/comments/comments0.c:20: WARNING: Block comments use a trailing */ on a separate line
+total: 1 errors, 5 warnings, 20 lines checked