Set texture api (google#2379)

* clone textures to prevent all like objects from pointing at the same texture instance * Adds bespoke api for setting texture maps * added nullness checks * removed metallicRoughness setters from material * removing API additions for now Co-authored-by: Emmett Lalish <[email protected]>
Synantoo · May 14, 2021 · 4d766f7 · 4d766f7
1 parent 2baee76
commit 4d766f7
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/packages/model-viewer/src/three-components/gltf-instance/ModelViewerGLTFInstance.ts b/packages/model-viewer/src/three-components/gltf-instance/ModelViewerGLTFInstance.ts
@@ -177,6 +177,24 @@ export class ModelViewerGLTFInstance extends GLTFInstance {
     }
 
     const clone = material.clone() as MeshStandardMaterial;
+    if (material.map != null) {
+      material.map = material.map.clone();
+    }
+    if (material.normalMap != null) {
+      material.normalMap = material.normalMap.clone();
+    }
+    if (material.aoMap != null) {
+      material.aoMap = material.aoMap.clone();
+    }
+    if (material.emissiveMap != null) {
+      material.emissiveMap = material.emissiveMap.clone();
+    }
+    if (material.metalnessMap != null) {
+      material.metalnessMap = material.metalnessMap.clone();
+    }
+    if (material.roughnessMap != null) {
+      material.roughnessMap = material.roughnessMap.clone();
+    }
 
     // This allows us to patch three's materials, on top of patches already
     // made, for instance GLTFLoader patches SpecularGlossiness materials.