Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a option for local search to fido client #143

Merged
merged 15 commits into from
Feb 10, 2025

Conversation

nicHoch
Copy link
Contributor

@nicHoch nicHoch commented Sep 19, 2024

No description provided.

@nicHoch nicHoch requested a review from samaloney September 19, 2024 12:18
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.31%. Comparing base (35c88f3) to head (5717a53).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
stixpy/net/client.py 95.52% 3 Missing ⚠️
stixpy/net/attrs.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   73.56%   75.31%   +1.75%     
==========================================
  Files          32       32              
  Lines        2016     2111      +95     
==========================================
+ Hits         1483     1590     +107     
+ Misses        533      521      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should switch to anc, asp, ephemeris for level, datatype and product so remove aux etc?

I don't think we need to add so many files I know they are empty but should be able to just mock the list of file names similar to here but for a local client https://github.com/sunpy/radiospectra/blob/main/radiospectra/net/sources/tests/test_rstn_client.py

Also need to think about the versions thing what happens if you search for both min and latest specifically how if works with https://docs.sunpy.org/en/latest/topic_guide/extending_fido.html#search-attrs

It may be better as function which operates on the Fido.search result?

Not sure if the test fail is real or just a typo?

Copy link
Contributor

@ayshih ayshih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some (trivial) regex comments/suggestions

Comment on lines 44 to 72
ql_filename = r"solo_{level}_stix-{product}_[0-9]{{8}}_V[0-9]{{2}}[a-zA-Z]?.fits"
sci_filename = (
r"solo_{level}_stix-{product}_" r"[0-9]{{8}}T[0-9]{{6}}-[0-9]{{8}}T[0-9]{{6}}_V[0-9]{{2}}[a-zA-Z]?_.*.fits"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Did the changes to ql_filename an sci_filename actually affect matching? Your commit message implies that you made these changes for Windows, but I don't immediately see how that would be the case.
  • The period in .fits should formally be escaped

@samaloney samaloney changed the title add a option for local search to fido client Add a option for local search to fido client Jan 31, 2025
nicHoch and others added 4 commits February 10, 2025 16:03
Co-authored-by: Shane Maloney <[email protected]>
Co-authored-by: Shane Maloney <[email protected]>
Co-authored-by: Shane Maloney <[email protected]>
@samaloney samaloney merged commit e3d8d61 into TCDSolar:main Feb 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants