Imaging Convenience Tools #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulating calibrated visibilities.
|
@samaloney Would something like this be within scope for STIXpy? |
samaloney
reviewed
Nov 15, 2024
| @@ -72,3 +75,45 @@ def wcs(self): | |||
| # Validate the WCS here. | |||
| w2.wcs.set() | |||
| return w2 | |||
|
|
|||
| def to_hpc(self, | |||
There was a problem hiding this comment.
This is a transform like any other so we should do it via the standard API can include this shortcut in the transformation code I think - need to think about this a bit more.
There was a problem hiding this comment.
OK, I think that makes sense.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 73.56% 71.96% -1.60%
==========================================
Files 32 33 +1
Lines 2016 2083 +67
==========================================
+ Hits 1483 1499 +16
- Misses 533 584 +51 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes some convenience tools for condensing a some common tasks that are mostly well-defined but currently take many lines of code.