Refactor(typescript)/error handling (nomic-ai#1283)

* actually display error if it occurs while instantiating * bump version
TPVinnie · Jul 27, 2023 · 0e866a0 · 0e866a0
1 parent 9100b2e
commit 0e866a0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/gpt4all-bindings/typescript/index.cc b/gpt4all-bindings/typescript/index.cc
@@ -58,10 +58,13 @@ Napi::Function NodeModelWrapper::GetClass(Napi::Env env) {
         }
     }
     llmodel_set_implementation_search_path(library_path.c_str());
-    llmodel_error* e = nullptr;
-    inference_ = std::make_shared<llmodel_model>(llmodel_model_create2(full_weight_path.c_str(), "auto", e));
-    if(e != nullptr) {
-       Napi::Error::New(env, e->message).ThrowAsJavaScriptException(); 
+    llmodel_error e = {
+        .message="looks good to me",
+        .code=0,
+    };
+    inference_ = std::make_shared<llmodel_model>(llmodel_model_create2(full_weight_path.c_str(), "auto", &e));
+    if(e.code != 0) {
+       Napi::Error::New(env, e.message).ThrowAsJavaScriptException(); 
        return;
     }
     if(GetInference() == nullptr) {

diff --git a/gpt4all-bindings/typescript/package.json b/gpt4all-bindings/typescript/package.json
@@ -1,6 +1,6 @@
 {
   "name": "gpt4all",
-  "version": "2.1.0-alpha",
+  "version": "2.1.1-alpha",
   "packageManager": "[email protected]",
   "main": "src/gpt4all.js",
   "repository": "nomic-ai/gpt4all",