fix: change number children (Orillusion#279)

change number children
TSZEQ · Aug 10, 2023 · f066490 · f066490
1 parent b9d57d4
commit f066490
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/components/Transform.ts b/src/components/Transform.ts
@@ -133,7 +133,7 @@ export class Transform extends ComponentBase {
         } else {
             this._scene3d = hasRoot;
             for (let c of this.object3D.components.values()) {
-                ComponentCollect.appendWaitStart(this.object3D, c);
+                ComponentCollect.appendWaitStart(c);
             }
         }
 

diff --git a/src/core/entities/Entity.ts b/src/core/entities/Entity.ts
@@ -3,9 +3,8 @@ import { RenderNode } from '../../components/renderer/RenderNode';
 import { Transform } from '../../components/Transform';
 import { CEventDispatcher } from '../../event/CEventDispatcher';
 import { RenderLayer } from '../../gfx/renderJob/config/RenderLayer';
-import { Vector3 } from '../../math/Vector3';
 import { BoundUtil } from '../../util/BoundUtil';
-import { GetCountInstanceID, UUID } from '../../util/Global';
+import { GetCountInstanceID } from '../../util/Global';
 import { BoundingBox } from '../bound/BoundingBox';
 import { IBound } from '../bound/IBound';
 import { Object3D } from './Object3D';
@@ -24,6 +23,7 @@ export class Entity extends CEventDispatcher {
     public name: string = '';
 
     protected readonly _instanceID: string = '';
+    private _numChildren: number;
 
     /**
      * The unique identifier of the object.
@@ -62,9 +62,6 @@ export class Entity extends CEventDispatcher {
     public components: Map<any, IComponent>;
 
 
-    public numChildren: number = 0;
-
-
     protected waitDisposeComponents: IComponent[];
 
     /**
@@ -132,7 +129,7 @@ export class Entity extends CEventDispatcher {
      * Returns the number of child objects of an object
      */
     public get numChildren(): number {
-        return this.entityChildren.length;
+        return this._numChildren;
     }
 
     /**
@@ -157,7 +154,7 @@ export class Entity extends CEventDispatcher {
             }
             child.transform.parent = this.transform;
             this.entityChildren.push(child);
-            this.numChildren = this.entityChildren.length;
+            this._numChildren = this.entityChildren.length;
             return child;
         }
         return null;
@@ -175,7 +172,7 @@ export class Entity extends CEventDispatcher {
         if (index != -1) {
             this.entityChildren.splice(index, 1);
             child.transform.parent = null;
-            this.numChildren = this.entityChildren.length;
+            this._numChildren = this.entityChildren.length;
         }
     }