forked from corda/corda
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into m4ksio_gradle_no_o_fix
# Conflicts: # constants.properties
- Loading branch information
Showing
3,809 changed files
with
24,230 additions
and
340,434 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# !! DO NOT MODIFY THE API FILE IN THIS DIRECTORY !! | ||
|
||
The `api-current.txt` file contains a summary of Corda's current public APIs, | ||
as generated by the `api-scanner` Gradle plugin. (See [here](../gradle-plugins/api-scanner/README.md) for a detailed description of this plugin.) It will be regenerated and the copy in this repository updated by the Release Manager with | ||
each new Corda release. It will not be modified otherwise except under special circumstances that will require extra approval. | ||
|
||
Deleting or changing the existing Corda APIs listed in `api-current.txt` may | ||
break developers' CorDapps in the next Corda release! Please remember that we | ||
have committed to API Stability for CorDapps. | ||
|
||
# !! DO NOT MODIFY THE API FILE IN THIS DIRECTORY !! |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
#!/bin/bash | ||
|
||
echo "Starting API Diff" | ||
|
||
APIHOME=$(dirname $0) | ||
|
||
apiCurrent=$APIHOME/api-current.txt | ||
if [ ! -f $apiCurrent ]; then | ||
echo "Missing $apiCurrent file - cannot check API diff. Please rebase or add it to this release" | ||
exit -1 | ||
fi | ||
|
||
diffContents=`diff -u $apiCurrent $APIHOME/../build/api/api-corda-*.txt` | ||
echo "Diff contents:" | ||
echo "$diffContents" | ||
echo | ||
|
||
# A removed line means that an API was either deleted or modified. | ||
removals=$(echo "$diffContents" | grep "^-\s") | ||
removalCount=`grep -v "^$" <<EOF | wc -l | ||
$removals | ||
EOF | ||
` | ||
|
||
echo "Number of API removals/changes: "$removalCount | ||
if [ $removalCount -gt 0 ]; then | ||
echo "$removals" | ||
echo | ||
fi | ||
|
||
# Adding new abstract methods could also break the API. | ||
newAbstracts=$(echo "$diffContents" | grep "^+\s" | grep "\(public\|protected\) abstract") | ||
abstractCount=`grep -v "^$" <<EOF | wc -l | ||
$newAbstracts | ||
EOF | ||
` | ||
|
||
echo "Number of new abstract APIs: "$abstractCount | ||
if [ $abstractCount -gt 0 ]; then | ||
echo "$newAbstracts" | ||
echo | ||
fi | ||
|
||
badChanges=$(($removalCount + $abstractCount)) | ||
|
||
echo "Exiting with exit code" $badChanges | ||
exit $badChanges |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,11 @@ | ||
Thank you for choosing to contribute to Corda. | ||
👮🏻👮🏻👮🏻 !!!! DESCRIBE YOUR CHANGES HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻 | ||
|
||
Your PR must be approved by one or more reviewers and all tests must be passed on TeamCity (https://ci.corda.r3cev.com) in order to be merged. | ||
|
||
Once you have submitted a PR you are responsible for keeping it up to date until the time it is merged. | ||
# PR Checklist: | ||
|
||
PR Checklist: | ||
- [ ] Have you run the unit, integration and smoke tests as described here? https://docs.corda.net/head/testing.html | ||
- [ ] If you added/changed public APIs, did you write/update the JavaDocs? | ||
- [ ] If the changes are of interest to application developers, have you added them to the changelog, and potentially release notes? | ||
- [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add to this Pull Request that you agree to it. | ||
|
||
1. Ensure any new code is tested as described in https://docs.corda.net/testing.html | ||
2. Ensure you have done any relevant automated testing and manual testing | ||
3. Add your changes to docs/source/changelog.rst | ||
4. Update any documentation in docs/source relating to your changes and learn how to build them in https://docs.corda.net/building-the-docs.html | ||
5. If you are contributing for the first time please read the agreement in CONTRIBUTING.md now and add to this Pull Request that you have read, and agreed to, the agreement. | ||
|
||
Please remove this message when you have read it. | ||
Thanks for your code, it's appreciated! :) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.