Skip to content

Commit

Permalink
Update completion tests to account for triggerParameterHints
Browse files Browse the repository at this point in the history
  • Loading branch information
DanTup committed Nov 16, 2021
1 parent 434b509 commit d2a4e85
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/test/dart/providers/completion_item_provider.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ main() {

const cl: LazyCompletionItem = ensureCompletion(completions, vs.CompletionItemKind.Method, "methodWithArgsAndReturnValue(…)", "methodWithArgsAndReturnValue");
assert.equal(cl.additionalTextEdits, undefined); // Tested in the unimported imports test.
assert.equal(cl.command, undefined); // Tested in the unimported imports in part-file test.
assert.equal(cl.command!.command, "editor.action.triggerParameterHints");
assert.equal(cl.commitCharacters, undefined); // TODO: ??
assert.equal(cl.detail, "(int i) → int"); // No auto import message here
assert.equal(cl.filterText, "methodWithArgsAndReturnValue");
Expand Down Expand Up @@ -224,7 +224,7 @@ main() {
const completion = ensureCompletion(completions, vs.CompletionItemKind.Constructor, "ProcessInfo()", "ProcessInfo");

assert.ok(completion.additionalTextEdits!.length);
assert.equal(completion.command, undefined); // Tested in the unimported imports in part-file test.
assert.equal(completion.command!.command, "editor.action.triggerParameterHints");
assert.equal(completion.commitCharacters, undefined); // TODO: ??
assert.equal(completion.detail, "Auto import from 'dart:io'\n\n() → ProcessInfo");
if (extApi.isLsp) {
Expand Down Expand Up @@ -260,7 +260,7 @@ main() {
const completion = ensureCompletion(completions, vs.CompletionItemKind.Constructor, "HashMap(…)", "HashMap");

assert.ok(completion.additionalTextEdits!.length);
assert.equal(completion.command, undefined); // Tested in the unimported imports in part-file test.
assert.equal(completion.command!.command, "editor.action.triggerParameterHints");
assert.equal(completion.commitCharacters, undefined); // TODO: ??
// This signature changed in a newer Dev version of Dart (2020-05-13).
assert.ok(
Expand Down

0 comments on commit d2a4e85

Please sign in to comment.